Home  |  Linux  | Mysql  | PHP  | XML
From:Hannes Magnusson Date:Fri Oct  3 01:25:24 2008
Subject:Re: Two more phd patches
On Fri, Oct 3, 2008 at 09:17, Christian Weiske <cweiske@cweiske.de> wrote:
> Hello,
>
>
> Attached are two phd patches that
> a) only fetch pear css files when they don't exist yet
> b) catch when getChildren() for a non-existing id is called. (happens in
> broken xml)
>


All these patches look fine - although I'd recommend
isset($array["key"]) over array_key_exists("key", $array) since
isset() is heckofalot faster (and it really matters in these functions
as they are executed at least 15.000 times..).

-Hannes
p.s. You should have PhD karma as of now, feel free to commit yourself :)
Navigate in group php.doc at sever news.php.net
Previous Next




  
© No Copyright
You are free to use Anything
Site Maintained by PHP Developer
Powered By PHP Consultants