Home  |  Linux  | Mysql  | PHP  | XML
From:Andrei Zmievski Date:Sun Sep 21 16:45:11 2008
Subject:Re: cvs: php-gtk /main phpg_gobject.c
Ok, I fixed it. :) But you broke it. :)

-Andrei

Andrei Zmievski wrote:
> andrei		Sun Sep 21 22:39:53 2008 UTC
> 
>   Modified files:              
>     /php-gtk/main	phpg_gobject.c 
>   Log:
>   Fixed crash related to 5.3 refcounting macros misuse.
>   
>   Z_REFCOUNT_P() has changed in 5.3 to access refcount_gp instead of
>   refcount, and thus must be used only for accessing zval's. In this case,
>   _store_object has a refcount, but is not a zval.
>   
>   
> http://cvs.php.net/viewvc.cgi/php-gtk/main/phpg_gobject.c?r1=1.68&r2=1.69&diff_format=u
> Index: php-gtk/main/phpg_gobject.c
> diff -u php-gtk/main/phpg_gobject.c:1.68 php-gtk/main/phpg_gobject.c:1.69
> --- php-gtk/main/phpg_gobject.c:1.68	Fri Feb 29 19:05:53 2008
> +++ php-gtk/main/phpg_gobject.c	Sun Sep 21 22:39:53 2008
> @@ -124,7 +124,7 @@
>      struct _store_object *stored = &EG(objects_store).object_buckets[handle].bucket.obj;
>      phpg_gobject_t *pobj = (phpg_gobject_t *) stored->object;
>  
> -    if (EG(objects_store).object_buckets[handle].valid && Z_REFCOUNT_P(stored) == 1) {	
> +    if (EG(objects_store).object_buckets[handle].valid && stored->refcount == 1) {	
>          if (pobj->obj && pobj->obj->ref_count > 1) {
>              pobj->is_owned = TRUE;
>              g_object_set_qdata_full(pobj->obj, gobject_wrapper_owned_key, (void *)handle, phpg_unref_by_handle);
> 
> 
> 
Navigate in group php.gtk.cvs at sever news.php.net
Previous Next




  
© No Copyright
You are free to use Anything
Site Maintained by PHP Developer
Powered By PHP Consultants