From:	byterock@cvs.perl.org	Date:	Thu Jul 31 09:06:54 2008
Subject:	[svn:dbd-oracle] r11618 - dbd-oracle/trunk

Author: byterock
Date: Thu Jul 31 08:06:53 2008
New Revision: 11618

Modified:
   dbd-oracle/trunk/Oracle.pm
   dbd-oracle/trunk/Oracle.xs
   dbd-oracle/trunk/oci8.c

Log:
Latest changed new RC next

Modified: dbd-oracle/trunk/Oracle.pm
==============================================================================
--- dbd-oracle/trunk/Oracle.pm	(original)
+++ dbd-oracle/trunk/Oracle.pm	Thu Jul 31 08:06:53 2008
@@ -3145,6 +3145,8 @@
   
 Below are the limitations of Remote LOBs;
 
+=over
+
 =item Queries involving more than one database are not supported;
 
 so the following returns an error:

Modified: dbd-oracle/trunk/Oracle.xs
==============================================================================
--- dbd-oracle/trunk/Oracle.xs	(original)
+++ dbd-oracle/trunk/Oracle.xs	Thu Jul 31 08:06:53 2008
@@ -249,7 +249,7 @@
 	CODE:
 	/*simply does a call to OCIServerVersion which should make 1 round trip*/
     /*later I will replace this with the actual OCIPing command*/
-    /*This will work if the DB goes down, /*
+    /*This will work if the DB goes down, */
     /*If the listener goes down it is another case as the Listener is needed to establish the connection not maintain it*/
     /*so we should stay connected but we cannot get nay new connections*/
 	{

Modified: dbd-oracle/trunk/oci8.c
==============================================================================
--- dbd-oracle/trunk/oci8.c	(original)
+++ dbd-oracle/trunk/oci8.c	Thu Jul 31 08:06:53 2008
@@ -1632,7 +1632,7 @@
   dTHX;
   text		str_buf[200];
   double   	dnum;
-  ub4      	str_len;
+  size_t   	str_len;
   OCIRaw   	*raw = (OCIRaw *) 0;
   OCIString	*vs = (OCIString *) 0;
   ub1      	*temp = (ub1 *)0;
@@ -3394,18 +3394,18 @@
     if (status == OCI_SUCCESS) { /* There is a synonym, get the schema */
     	char *syn_schema=NULL, *syn_name=NULL;
     	char new_tablename[100];
-    	ub4 syn_schema_len = 0, syn_name_len = 0;
+    	ub4 syn_schema_len = 0, syn_name_len = 0,tn_len;
       	OCIAttrGet_log_stat(imp_sth->dschp,  OCI_HTYPE_DESCRIBE,
-				  &parmhp, 0, OCI_ATTR_PARAM, errhp, status);
+				  &parmhp, 0, OCI_ATTR_PARAM, errhp, status);				  
       	OCIAttrGet_log_stat(parmhp, OCI_DTYPE_PARAM,
-			  &syn_schema, &syn_schema_len, OCI_ATTR_SCHEMA_NAME, errhp, status);
+      		      &syn_schema, &syn_schema_len, OCI_ATTR_SCHEMA_NAME, errhp, status);
 		OCIAttrGet_log_stat(parmhp, OCI_DTYPE_PARAM,
-			  &syn_name, &syn_name_len, OCI_ATTR_OBJ_NAME, errhp, status);
+			      &syn_name, &syn_name_len, OCI_ATTR_OBJ_NAME, errhp, status);
 		OCIAttrGet_log_stat(parmhp, OCI_DTYPE_PARAM,
-			  &tablename, &tablename_len, OCI_ATTR_NAME, errhp, status);
+			      &tablename, &tn_len, OCI_ATTR_NAME, errhp, status);
 		strcpy(new_tablename,syn_schema);
 		strcat(new_tablename, ".");
-      	strncat(new_tablename, tablename,tablename_len);
+      	strncat(new_tablename, tablename,tn_len);
 	    tablename=new_tablename;
 
 	    if (DBIS->debug >= 3 || dbd_verbose >= 3)