Re: Plagia-Bot
Lawrence D’Oliveiro <[email protected]>
| Newsgroups | comp.misc |
|---|---|
| Organization | A noiseless patient Spider |
| Message-ID | <[email protected]> |
On Fri, 7 Aug 2026 16:34:07 -0000 (UTC), Jim Jackson wrote:
> I saw the response - it was not mythical. It certainly looked weird,
> and plagarising.
Here’s a copy from my email notification:
I had a quick look through this commit and noticed a couple of
small things that might be worth considering.First, there are a
few `asyncio.ensure_future()` calls where the returned task isn’t
stored anywhere.From the docs, it looks like keeping a reference
to the task is recommended so it doesn’t get garbage-collected
while still running. `asyncio.create_task()`might be a better fit
here, or a `TaskGroup` could help manage the references
automatically.
Also noticed `_connect_async()` could be written a little more
cleanly by using an `else` block after the exception handling.
That keeps the successful connection path separate from the retry
case and makes the flow a bit easier to follow.
One other minor thing: explicitly inheriting from `object` isn’t
needed in Python 3 anymore. It doesn’t hurt, but it can be removed
for simplicity.
This appeared a few hours after my own posting
<https://community.asterisk.org/t/need-help-testing-testsuite-untwisted/113807/2>.