Re: Remaining breakage on apr-1.7.x branch

On Mon, 12 Sept 2022 at 17:21, William A Rowe Jr <[email protected]>
wrote:

> After deep study of the whole ring strict alias issue, I've come to
> the conclusion that
> the -resulting- binary is effectively the same, and my test case was
> swapping the
> apr .so files between builds of httpd 2.4.54 / apr 1.7.0 and httpd
> 2.4.x/ apr 1.7.x.
> Running httpd test, no errors were introduced, all binaries loaded and ran
> fine.
> Someone building Subversion might want to repeat that exercise.
>
> So this was entirely a work-around to ensure the grammar didn't escape
> notice
> when types and values were switched around in ways that a compiler might
> over-optimize. There were instances where -O3 could break apr at one point,
> and I'm wondering if this might have been that root cause?
>
> I think we can accept this very unusual (for a stable release branch)
> contortion,
> since code correctly compiled on either 1.7.0 or 1.7.branch appear to
> accomplish
> the same and are binary-stable, only using different syntaxes to get there.
>
> Any final thoughts before we simply release 1.7 branch as-is?
>
> I'm fine with both approaches.

Btw I've recently backported several fixes to 1.7.x branch:
[[[
  *) Fix attempt to free invalid memory on exit when apr_app is used
     on Windows. [Ivan Zhakov]
  *) Fix double free on exit when apr_app is used on Windows. [Ivan Zhakov]

  *) Fix a regression in apr_stat() for root path on Windows. [Ivan Zhakov]
]]]

And CMake/GitHub Actions stuff.

-- 
Ivan Zhakov