Re: svn commit: r1908503 - in /apr/apr/trunk: build/crypto.m4 crypto/apr_crypto_openssl.c

Hi Rainer;

On Mon, Mar 27, 2023 at 2:02 PM Rainer Jung <[email protected]> wrote:
>
> Am 18.03.23 um 17:33 schrieb [email protected]:
> >
> > @@ -113,15 +112,13 @@ AC_DEFUN([APU_CHECK_CRYPTO_OPENSSL], [
> >         AC_MSG_NOTICE(checking for openssl in $withval)
> >         AC_CHECK_HEADERS(openssl/x509.h, [openssl_have_headers=1])
> >         AC_CHECK_LIB(crypto, EVP_CIPHER_CTX_new, openssl_have_libs=1)
> > -      if test "$openssl_have_headers" != "0" && test "$openssl_have_libs" != "0"; then
> > +      if test "$openssl_have_headers" = "1" && test "$openssl_have_libs" = "1"; then
> >           apu_have_openssl=1
> > -        APR_ADDTO(LDFLAGS, [-L$withval/lib])
> > -        APR_ADDTO(INCLUDES, [-I$withval/include])
>  >         fi
>  > -
>  > -      AC_CHECK_DECLS([EVP_PKEY_CTX_new, OPENSSL_init_crypto], [], [],
>  > -                     [#include <openssl/evp.h>])
>  > -
>  > +    fi
>  > +    if test "$apu_have_openssl" = "1"; then
>  > +        AC_CHECK_LIB(crypto, OPENSSL_init_crypto)
>  > +        AC_CHECK_FUNCS([OPENSSL_init_crypto])
>  >       fi
>
> Hmmm, for me this dropped "APR_ADDTO(INCLUDES,..." breaks the apr trunk
> build. The path to the OpenSSL header files gets no longer added to any
> INCLUDES variable for the build.

Ah yes, I thought both LDFLAGS and INCLUDES were already set above but
it is LDFLAGS and CPPFLAGS actually.
Restored in r1908749.

Thanks!
Yann.