Re: svn commit: r1917266 - in /apr/apr/trunk: buffer/apr_buffer.c include/apr_buffer.h test/testbuffer.c

On Wed, Apr 24, 2024 at 3:03 PM Yann Ylavic <[email protected]> wrote:
>
> APR_DECLARE(int) apr_buffer_cmp(const apr_buffer_t *src,
>                                 const apr_buffer_t *dst)
> {
>     apr_size_t slen, dlen;
>
>     if (!src) {
>         return dst ? 1 : 0;
>     }
>     if (!dst) {
>         return -1;
>     }
>     if (src->size != dst->size) {
>         return src->size < dst->size ? -1 : 1;
>     }
>
>     return memcmp(src->d.mem, dst->d.mem, slen);
> }
>
> Though I still don't think that we should handle NULLs here (let it crash..).

I meant:

APR_DECLARE(int) apr_buffer_cmp(const apr_buffer_t *src,
                                const apr_buffer_t *dst)
{
    apr_size_t slen, dlen;

    if (!src.d.mem) {
        return dst.d.mem ? 1 : 0;
    }
    if (!dst.d.mem) {
        return -1;
    }
    if (src->size != dst->size) {
        return src->size < dst->size ? -1 : 1;
    }

    return memcmp(src->d.mem, dst->d.mem, slen);
}