Re: svn commit: r1917094 [1/3] - in /apr/apr/trunk: ./ build/ docs/ include/ include/private/ ldap/ misc/unix/ test/

On 4/18/24 9:32 AM, [email protected] wrote:
> Author: minfrin
> Date: Thu Apr 18 07:32:13 2024
> New Revision: 1917094
> 
> URL: http://svn.apache.org/viewvc?rev=1917094&view=rev
> Log:
> apr_ldap: Add the new APR LDAP API.
> 
> - Async API, can be used safely in event driven code.
> - Requests are tied into a pool lifetime, with abandon if the pool is
>   cleaned early.
> - Initial support for SASL bind, compare and search.
> - Backportable to apr-util v1.7.
> - Test case with example implementation.
> - Unmaintained Mozilla/Netware API support removed.
> - Rebind removed pending async re-implementation.
> - Doxygen docs.
> 
> Added:
>     apr/apr/trunk/build/ldap.m4
>     apr/apr/trunk/include/private/apr_ldap_internal.h   (with props)
>     apr/apr/trunk/ldap/
>     apr/apr/trunk/ldap/apr_ldap.c   (with props)
>     apr/apr/trunk/ldap/apr_ldap_stub.c   (with props)
>     apr/apr/trunk/ldap/apr_ldap_url.c   (with props)
> Modified:
>     apr/apr/trunk/CHANGES
>     apr/apr/trunk/CMakeLists.txt
>     apr/apr/trunk/Makefile.in
>     apr/apr/trunk/build.conf
>     apr/apr/trunk/build/dso.m4
>     apr/apr/trunk/configure.in
>     apr/apr/trunk/docs/doxygen.conf
>     apr/apr/trunk/include/apr.h.in
>     apr/apr/trunk/include/apr.hnw
>     apr/apr/trunk/include/apr.hw
>     apr/apr/trunk/include/apr.hwc
>     apr/apr/trunk/include/apu_errno.h
>     apr/apr/trunk/misc/unix/errorcodes.c
>     apr/apr/trunk/test/Makefile.in
>     apr/apr/trunk/test/Makefile.win
>     apr/apr/trunk/test/abts_tests.h
>     apr/apr/trunk/test/testutil.h
> 

> 
> Modified: apr/apr/trunk/configure.in
> URL: http://svn.apache.org/viewvc/apr/apr/trunk/configure.in?rev=1917094&r1=1917093&r2=1917094&view=diff
> ==============================================================================
> --- apr/apr/trunk/configure.in (original)
> +++ apr/apr/trunk/configure.in Thu Apr 18 07:32:13 2024
> @@ -34,6 +34,7 @@ sinclude(build/dbm.m4)
>  sinclude(build/dbd.m4)
>  sinclude(build/dso.m4)
>  sinclude(build/iconv.m4)
> +sinclude(build/ldap.m4)
>  
>  sinclude(build/ax_prog_cc_for_build.m4)
>  
> @@ -3150,6 +3151,9 @@ APU_CHECK_DBD_SQLITE2
>  APU_CHECK_DBD_ORACLE
>  APU_CHECK_DBD_ODBC
>  
> +dnl Find LDAP backend
> +APU_FIND_LDAP
> +
>  dnl select an XML parser
>  APU_FIND_XML
>  
> @@ -3174,6 +3178,8 @@ if test "$crypt_r" = "1"; then
>    APU_CHECK_CRYPT_R_STYLE
>  fi
>  
> +AC_CHECK_HEADERS([sasl.h sasl/sasl.h])
> +

Why do we check for sasl.h again (besides in ldap.m4) and do so uncoditionally?

>  APRUTIL_LIBNAME="aprutil${libsuffix}"
>  AC_SUBST(APRUTIL_LIBNAME)
>  
> 

Regards

Rüdiger