Re: svn commit: r1924334 - /apr/apr-util/branches/1.7.x/CMakeLists.txt

On Wed, 12 Mar 2025 at 17:01, Graham Leggett <[email protected]> wrote:

> On 12 Mar 2025, at 15:37, Ivan Zhakov via dev <[email protected]> wrote:
>
>    ADD_EXECUTABLE(testall ${APR_TEST_SOURCES})
>
>> -  TARGET_LINK_LIBRARIES(testall ${whichapr})
>> +  TARGET_LINK_LIBRARIES(testall ${whichapr} ${LDAP_LIBRARIES})
>>    TARGET_COMPILE_DEFINITIONS(testall PRIVATE
>> "BINPATH=$<TARGET_FILE_DIR:testall>")
>>
>> Dependencies should be configured for apr/apr-util library itself: CMake
> should use library dependencies when properly configured.
>
>
> The legacy tests access Windows LDAP functions directly, and as a result
> without the above linking fails and the build fails. Reinstating this made
> the build work again.
>
> Oops, I wasn't aware that legacy tests access Windows LDAP functions
directly. Yes, in this case they should be declared as dependency for
testall program.


> Note that the apr-trunk has no legacy tests, and no need to link to
> anything, this is purely an apr-util problem.
>
> ok


-- 
Ivan Zhakov