Re: svn commit: r1927937 - in apr/apr/trunk: . test uri

Joe Orton <[email protected]> Wed, 27 Aug 2025 10:48:38 +0100

Newsgroups	gmane.comp.apache.apr.devel
Organization	Registered in England and Wales under Company Registration No. 03798903 Directors: Michael Cunningham (US), Michael O'Neill (Ireland), Paul Argiry (US)
Message-ID	<[email protected]>

On Tue, Aug 26, 2025 at 12:16:35PM +0200, Ruediger Pluem wrote:
...
> @@ -134,7 +144,11 @@
>      size_t offset;
>      char *hostcopy;
> 
> -    if (s == NULL) {
> +    if ((s == NULL) || strncasecmp(uptr->hostname, "fe80:", 5)) {
> +        /*
> +         * Scope id's are only allowed for link-local addresses under prefix
> +         * fe80::/10.
> +         */
>          return uptr->hostname;
>      }
> 
> 
> Hence we only do all this for fe80::/10 networks. For other networks we don't care and leave everything as is as we did before the
> initial patch. Still or further concerns?

That is testing for fe80::/16 rather than /10, might need to push it 
through apr_ipsubnet_* to test for /10?