Re: svn commit: r1704177 - in /serf/trunk/test/certs: ./ private/

On Sun, Sep 20, 2015 at 9:28 PM,  <[email protected]> wrote:
> Author: astieger
> Date: Sun Sep 20 19:28:07 2015
> New Revision: 1704177
>
> URL: http://svn.apache.org/viewvc?rev=1704177&view=rev
> Log:
> Follow-up to r1699934: Fix test_ssl_server_cert_with_san_and_empty_cb
>
> create_certs.py was changed to generate serfserver_san_nocn_cert.pem
> and assumingly it had been run to do that. This will have locally
> regenerated the root and intermediate locally to which the new cert
> matched, but they were never committed. Fix test from checkout by
> running script again.
>

Good catch! I knew that regenerating all certs fixed the test, but
OpenSSL's error message was not helpful enough to figure out why.

> Also adds the generated serfclientcert.pem to version control.

For which purpose?

thanks,

Lieven

>
> * test/certs/serf*.pem,
>   test/certs/serf*.p12,
>   test/certs/private/*.pem: regenerate with create_certs.py
> * test/certs/serfclientcert.pem: add generated file
>
> Added:
>     serf/trunk/test/certs/serfclientcert.pem
> Modified:
>     serf/trunk/test/certs/private/serfcakey.pem
>     serf/trunk/test/certs/private/serfclientkey.pem
>     serf/trunk/test/certs/private/serfrootcakey.pem
>     serf/trunk/test/certs/private/serfserverkey.pem
>     serf/trunk/test/certs/serfcacert.pem
>     serf/trunk/test/certs/serfclientcert.p12
>     serf/trunk/test/certs/serfrootcacert.pem
>     serf/trunk/test/certs/serfserver_expired_cert.pem
>     serf/trunk/test/certs/serfserver_future_cert.pem
>     serf/trunk/test/certs/serfserver_san_nocn_cert.pem
>     serf/trunk/test/certs/serfservercert.pem
>     serf/trunk/test/certs/serfservercrl.pem
>
[..]