Re: [RELEASE CANDIDATE] libapreq2 2.08-RC1

Philip M. Gollucci wrote:
>> - When I ran "perl Makefile.PL --with-apache2=C:/apache2" I got an 
>> error from win32/Configure.pl about Archive-Tar being missing, but 
>> this is not mentioned in the PREREQUISITES file and was not checked by 
>> test_prereq in Makefile.PL before calling this script.
> Committed revision 408136

This doesn't seem to do anything for me.  When I run Makefile.PL without 
Archive-Tar present it just fails as before:

Can't locate Archive/Tar.pm in @INC (@INC contains: C:/perl5mt/lib 
C:/perl5mt/site/lib .) at win32/Configure.pl line 11.
BEGIN failed--compilation aborted at win32/Configure.pl line 11.
system C:\perl5mt\bin\perl.exe win32/Configure.pl 
--with-apache2-apxs="C:\apache2\bin\apxs.bat" 
--with-perl="C:\perl5mt\bin\perl.exe" --with-apache2="C:/apache2" 
--enable-perl-glue failed: 512 at Makefile.PL line 88.

Something like the attached patch at least gets the check done before 
win32/Configure.pl is run, but even then it still carries on after the 
failed check and crashes just the same:

Can't locate Archive/Tar.pm in @INC (@INC contains: C:/perl5mt/lib 
C:/perl5mt/site/lib .) at build/version_check.pl line 42.
Please upgrade Archive::Tar first.
C:\perl5mt\bin\perl.exe win32/Configure.pl 
--with-apache2-apxs="C:\apache2\bin\apxs.bat" 
--with-perl="C:\perl5mt\bin\perl.exe" --with-apache2="C:/apache2" 
--enable-perl-glue
Can't locate Archive/Tar.pm in @INC (@INC contains: C:/perl5mt/lib 
C:/perl5mt/site/lib .) at win32/Configure.pl line 11.
BEGIN failed--compilation aborted at win32/Configure.pl line 11.
system C:\perl5mt\bin\perl.exe win32/Configure.pl 
--with-apache2-apxs="C:\apache2\bin\apxs.bat" 
--with-perl="C:\perl5mt\bin\perl.exe" --with-apache2="C:/apache2" 
--enable-perl-glue failed: 512 at Makefile.PL line 92.

Shouldn't test_prereq stop Makefile.PL on failure rather than just warning?


------------------------------------------------
Radan Computational Ltd.

The information contained in this message and any files transmitted with it are confidential and intended for the addressee(s) only. If you have received this message in error or there are any problems, please notify the sender immediately. The unauthorized use, disclosure, copying or alteration of this message is strictly forbidden. Note that any views or opinions presented in this email are solely those of the author and do not necessarily represent those of Radan Computational Ltd. The recipient(s) of this message should check it and any attached files for viruses: Radan Computational will accept no liability for any damage caused by any virus transmitted by this email.

--- Makefile.PL.orig	2006-05-22 09:09:18.000000000 +0100
+++ Makefile.PL	2006-05-22 09:17:21.645269900 +0100
@@ -41,6 +41,10 @@
     test_prereq "Test::More";
 }
 
+if (WIN32) {
+    test_prereq "Archive::Tar";
+}
+
 $opts .= "--debug " if (WIN32 and $args{debug});
 
 delete @args{@flags};