Re: Fixed: Truncated uploads in mod_perl 1 from FF2.0/Win
Issac Goldstand <[email protected]>
| Newsgroups | gmane.comp.apache.apreq |
|---|---|
| Organization | Mirimar Networks |
| Message-ID | <[email protected]> |
Joe Schaefer wrote: > Joe Schaefer <[email protected]> writes: > >> Right, since it's the start of a boundary. I think the best way >> to fix this is to do what php does and add a loop into fill_buffer >> so it completely fills the buffer instead of doing a single read. >> Php uses our multipart code for handling uploads, and that's probably >> why they haven't seen this bug crop up. > > Issac, are you interested in volunteering to be release manager > for a libapreq1 maintenance release? Looks like we need to do that, > but I personally have no interest in championing it through myself. Sure. I have some time now. To be candid, I haven't RM-ed inside an ASF project yet, so I could probably use a quick checklist from you or Phillip. > In the meantime I'll commit my patch unless someone thinks > there's a better solution available. I'm +1 on the patch Issac