Re: [PATCH] Some windows build enhancements
Mladen Turk <[email protected]>
| Newsgroups | gmane.comp.apache.apreq |
|---|---|
| Message-ID | <[email protected]> |
Philip M. Gollucci wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > Mladen Turk wrote: > | Hi, > | > | libapreq is missing .rc file, so here is a standard ASF one. > | Also, added APREQ_DECLARE_EXPORT/APREQ_DECLARE_STATIC > | in the same way as APR declares so that dllexport/dllimport > | get correctly handled. > Hi Mladen, > > Thanks for your work on this. In the future, please submit patches > piece wise. > > Committed to trunk: 651366, 651374, 651381, 651385, 651388 > > backported to v2_10 branch: 651399. > ACK. There was one small typo and it seems I have the karma for commits, so I've fixed it directly. I suppose the fix has to go to the 2.10 branch as well. Regards -- (TM)