Re: svn commit: r734232 - /httpd/apreq/trunk/library/module_cgi.c

Joe Schaefer wrote:
> ----- Original Message ----
>
>   
>> From: Issac Goldstand <[email protected]>
>> To: Joe Schaefer <[email protected]>
>> Cc: [email protected]
>> Sent: Tuesday, January 13, 2009 3:53:53 PM
>> Subject: Re: svn commit: r734232 - /httpd/apreq/trunk/library/module_cgi.c
>>
>> A null char.  As I mentioned in the commit message to deal with this,
>> I'm not quite sure why I went through such pains to store a null
>> character and couldn't just use NULL or (char) 0 in the code where it
>> was needed.
>>
>> All I remember is some foggy issue with wide characters on win32, but I
>> don't remember exactly what (and no longer have the original development
>> environment for it)
>>
>> In any case, it passes on maintainer mode now, and I hope to get a
>> testbed up for win32/vc6 and win32/vc9 (bill, if you're listening, do
>> you generally test against vc8 or vc9?), and maybe even sparc solaris
>> 10, sunstudio 12 (if I can figure out how to set that up in the next few
>> days - I need such a compilation environment for work anyway, so may as
>> well test out new features there :))
>>
>> Sorry for the messy commit :-/
>>
>>   Issac
>>
>>
>> PS, a basic test of the patch is running modules/test_cgi after make
>> test.  If someone can think of a clever way to test this (which needs
>> stdin input) from Test::More, Apache::Test and friends, I can try to get
>> better unit-testing in place, too
>>     
>
> I like it already, cool how it prompts exactly for the desired params.
>   
Yeah, but it's still full of bugs, like how to tell it to not have a
param (esp if I add the API for setting default values for params)