Re: [PATCH] Restore Windows (and NeXT and NetWare etc) build of test suite following revision 1124400
Issac Goldstand <[email protected]> Mon, 20 Oct 2014 13:40:24 +0300
| Newsgroups | gmane.comp.apache.apreq |
|---|---|
| Message-ID | <[email protected]> |
Fixed in r1633096 Thank you! On 13/07/2014 16:35, Steve Hay wrote: > On 21 March 2014 22:17, Steve Hay <[email protected]> wrote: >> Testing a mod_perl & libapreq build on Windows I have come across a >> problem introduced into the current SVN trunk of libapreq by revision >> 1124400. >> >> The attached patch fixes the problem for me on Windows, and hopefully >> for any NeXT and NetWare users out there too, but it seems I don't >> have commit access to apreq. Please could somebody apply this (and >> even test the non-Windows cases first if possible too)? > > The original patch fixed the build on Windows, but not quite as > intended: It used nothing for the definition of AT_INLINE, instead of > using __inline as I had intended. (The main thing is not to use inline > (or __inline__), which MS VC++ doesn't understand.) > > The attached patch corrects that. >