Re: 2 Fatal Issues, Details

We don't need a lock file at all.

Sent from my iPhone

> On Nov 22, 2016, at 5:08 AM, Issac Goldstand <[email protected]> wrote:=

>=20
> apreq-devs:
>=20
> So looking at this, I accidentally committed bad logic with mod_version
> which led me to notice that tests don't seem to be failing without the
> offending LockFile even in Apache 2.2 (I tested
> mod_perl-2.10/httpd-2.2.31/perl-5.18 + mod_perl-2.10/httpd-2.4.23/perl-5.2=
4)
>=20
> Are people still using fcntl/flock lock files?  Do people think it's
> safe to drop the LockFile like I did, or should I be more cautious with
> something like this:
>=20
> <IfModule !mpm_winnt.c>
> <IfModule !mod_version.c>
>   LockFile @ServerRoot@/logs/accept.lock
> </IfModule>
> <IfModule mod_version.c>
> <IfVersion < 2.3.4>
>   LockFile @ServerRoot@/logs/accept.lock
> </IfVersion>
> </IfModule>
>   Mutex file:@ServerRoot@/logs default
> </IfModule>
>=20
>=20
>> On 11/15/2016 12:05 AM, William N. Braswell, Jr. wrote:
>> Mr. Goldstand,
>>=20
>> Yes, both of these 2 issues are causing fatal errors when trying to run
>> with the following setup:
>>=20
>> *  Perl 5, version 22, subversion 1 (v5.22.1) built for
>> x86_64-linux-gnu-thread-multi
>>=20
>> *  libapache2-mod-perl2 v2.0.9-4ubuntu1
>>=20
>> *  Apache/2.4.18 (Ubuntu)
>>=20
>> *  $Apache::Test::VERSION 1.39
>>=20
>> MORE INFO:
>>=20
>> LockFile no longer supported in Apache v2.4:
>> "Directives AcceptMutex, LockFile, RewriteLock, SSLMutex,
>> SSLStaplingMutex, and WatchdogMutexPath have been replaced with a single
>> Mutex directive. You will need to evaluate any use of these removed
>> directives in your 2.2 configuration to determine if they can just be
>> deleted or will need to be replaced using Mutex."
>> https://httpd.apache.org/docs/current/upgrading.html
>>=20
>> The need to call the extra "Include ... mpm*.load" lines is apparently
>> due to libapreq2 requiring mpm.  There is no web link with more info on
>> this error, because it is specific to libapreq2.
>>=20
>> Does that sufficiently answer your questions and concerns?
>>=20
>> Thanks,
>> ~ Will
>>=20
>>=20
>> On 11/14/2016 at 8:10 AM, "Issac Goldstand" <[email protected]> wrote:=

>>=20
>>    cc-ing the dev list for the apreq project
>>=20
>>    Hi,
>>=20
>>    I haven't tested this with the latest Perl/mod_perl/httpd stack
>>    (although this worked fine as-is last time we did a release).
>>=20
>>    While I dig into this by me (may take some cycles), would you explain
>>    why you think these changes need to be made? Are things breaking
>>    without them, and if so can you provide information about what version=
s
>>    of software (perl, mod_perl, httpd, and Apache::Test) you are using?
>>=20
>>    Thanks,
>>    Issac
>>=20
>>>    On 11/11/2016 3:00 PM, William N. Braswell, Jr. wrote:
>>> Hello Mr. Goldstand,
>>>=20
>>> I have found a bug in your libapreq2 software, which is a prerequisite
>>> to several other packages on CPAN.
>>>=20
>>> In this file:
>>>=20
>>> https://metacpan.org/source/ISAAC/libapreq2-2.13/module/t/conf/extra.con=
f.in
>>>=20
>>> The line which currently reads:
>>>=20
>>> LockFile @ServerRoot@/logs/accept.lock
>>>=20
>>> Should be changed to:
>>>=20
>>> Mutex file:@ServerRoot@/logs default
>>>=20
>>> ...
>>>=20
>>> Also, in the auto-generated file:
>>>=20
>>> libapreq2-2.13/module/t/conf/httpd.conf
>>>=20
>>> The following 2 lines need to be added:
>>>=20
>>> Include /etc/apache2/mods-enabled/mpm*.load
>>> Include /etc/apache2/mods-enabled/mpm*.conf
>>>=20
>>> ...
>>>=20
>>> Can you please make these changes and upload a new version of libapreq2
>>> to CPAN?
>>>=20
>>> I would be happy to help in any way I can.
>>>=20
>>> Thank you sir!
>>>=20
>>> ~ Will
>>=20
>=20