svn commit: r1934885 - in httpd/httpd/branches/2.4.x: . modules/filters support

Author: jorton
Date: Tue Jun  2 13:55:21 2026
New Revision: 1934885

Log:
Merge r1934594, r1934597 from trunk:

memchr() takes a char * as a first parameter, and 'buf' is a const char *.

This breaks build process at least with gcc 16.1.1 and maintainer-mode enabled.

Without maintainer-mode, only a warning is generated.

strchr() takes a char * as a first parameter, and in the cases a const char * is passed.

This breaks build process at least with gcc 16.1.1 and maintainer-mode enabled.

Without maintainer-mode, only a warning is generated.

Submitted by: jailletc36
Reviewed by: jailletc36, jim, jorton

Modified:
   httpd/httpd/branches/2.4.x/   (props changed)
   httpd/httpd/branches/2.4.x/modules/filters/sed1.c
   httpd/httpd/branches/2.4.x/support/ab.c
   httpd/httpd/branches/2.4.x/support/rotatelogs.c

Modified: httpd/httpd/branches/2.4.x/modules/filters/sed1.c
==============================================================================
--- httpd/httpd/branches/2.4.x/modules/filters/sed1.c	Tue Jun  2 13:54:17 2026	(r1934884)
+++ httpd/httpd/branches/2.4.x/modules/filters/sed1.c	Tue Jun  2 13:55:21 2026	(r1934885)
@@ -436,7 +436,7 @@ apr_status_t sed_eval_buffer(sed_eval_t
         char *n;
         apr_size_t llen;
 
-        n = memchr(buf, '\n', bufsz);
+        n = memchr((char *)buf, '\n', bufsz);
         if (n == NULL)
             break;
 

Modified: httpd/httpd/branches/2.4.x/support/ab.c
==============================================================================
--- httpd/httpd/branches/2.4.x/support/ab.c	Tue Jun  2 13:54:17 2026	(r1934884)
+++ httpd/httpd/branches/2.4.x/support/ab.c	Tue Jun  2 13:55:21 2026	(r1934885)
@@ -2261,7 +2261,7 @@ static int parse_url(const char *url)
     }
 #endif
 
-    if ((cp = strchr(url, '/')) == NULL)
+    if ((cp = strchr((char *)url, '/')) == NULL)
         return 1;
     h = apr_pstrmemdup(cntxt, url, cp - url);
     rv = apr_parse_addr_port(&hostname, &scope_id, &port, h, cntxt);
@@ -2537,7 +2537,7 @@ int main(int argc, const char * const ar
                     /*
                      * assume proxy-name[:port]
                      */
-                    if ((p = strchr(opt_arg, ':'))) {
+                    if ((p = strchr((char *)opt_arg, ':'))) {
                         *p = '\0';
                         p++;
                         proxyport = atoi(p);

Modified: httpd/httpd/branches/2.4.x/support/rotatelogs.c
==============================================================================
--- httpd/httpd/branches/2.4.x/support/rotatelogs.c	Tue Jun  2 13:54:17 2026	(r1934884)
+++ httpd/httpd/branches/2.4.x/support/rotatelogs.c	Tue Jun  2 13:55:21 2026	(r1934885)
@@ -542,16 +542,16 @@ static const char *get_time_or_size(rota
     char *ptr = NULL;
     /* Byte multiplier */
     unsigned int mult = 1;
-    if ((ptr = strchr(arg, 'B')) != NULL) { /* Found KB size */
+    if ((ptr = strchr((char *)arg, 'B')) != NULL) { /* Found KB size */
         mult = 1;
     }
-    else if ((ptr = strchr(arg, 'K')) != NULL) { /* Found KB size */
+    else if ((ptr = strchr((char *)arg, 'K')) != NULL) { /* Found KB size */
         mult = 1024;
     }
-    else if ((ptr = strchr(arg, 'M')) != NULL) { /* Found MB size */
+    else if ((ptr = strchr((char *)arg, 'M')) != NULL) { /* Found MB size */
         mult = 1024 * 1024;
     }
-    else if ((ptr = strchr(arg, 'G')) != NULL) { /* Found GB size */
+    else if ((ptr = strchr((char *)arg, 'G')) != NULL) { /* Found GB size */
         mult = 1024 * 1024 * 1024;
     }
     if (ptr) { /* rotation based on file size */