svn commit: r1936259 - httpd/httpd/trunk/modules/ssl

[email protected] Fri, 17 Jul 2026 12:12:12 -0000
Newsgroups gmane.comp.apache.cvs
Message-ID <178429033292.3837397.7025278379463626077@svn03-he-fi>
Author: jorton
Date: Fri Jul 17 12:12:12 2026
New Revision: 1936259

Log:
mod_ssl: fix NULL dereference in OCSP responder URI parsing

* modules/ssl/ssl_engine_ocsp.c (determine_responder_uri): Check
  u->scheme is non-NULL before calling ap_cstr_casecmp(), since
  apr_uri_parse() can succeed with a NULL scheme for scheme-less URIs.

Assisted-by: Claude Sonnet 4.6 <[email protected]>
GitHub: PR #685

Modified:
   httpd/httpd/trunk/modules/ssl/ssl_engine_ocsp.c

Modified: httpd/httpd/trunk/modules/ssl/ssl_engine_ocsp.c
==============================================================================
--- httpd/httpd/trunk/modules/ssl/ssl_engine_ocsp.c	Fri Jul 17 12:12:05 2026	(r1936258)
+++ httpd/httpd/trunk/modules/ssl/ssl_engine_ocsp.c	Fri Jul 17 12:12:12 2026	(r1936259)
@@ -80,7 +80,7 @@ static apr_uri_t *determine_responder_ur
     }
 
     rv = apr_uri_parse(p, s, u);
-    if (rv || !u->hostname) {
+    if (rv || !u->hostname || !u->scheme) {
         ap_log_cerror(APLOG_MARK, APLOG_DEBUG, rv, c, APLOGNO(01919)
                       "failed to parse OCSP responder URI '%s'", s);
         return NULL;