svn commit: r1936262 - httpd/httpd/trunk/modules/ssl

Author: jorton
Date: Fri Jul 17 12:12:40 2026
New Revision: 1936262

Log:
mod_ssl: fix set_challenge_creds() to return rv on failure

* modules/ssl/ssl_engine_kernel.c (set_challenge_creds): Return rv
  rather than APR_SUCCESS unconditionally, so credential setup
  failures are propagated to the ALPN selection callback.

Assisted-by: Claude Sonnet 4.6 <[email protected]>
GitHub: PR #685

Modified:
   httpd/httpd/trunk/modules/ssl/ssl_engine_kernel.c

Modified: httpd/httpd/trunk/modules/ssl/ssl_engine_kernel.c
==============================================================================
--- httpd/httpd/trunk/modules/ssl/ssl_engine_kernel.c	Fri Jul 17 12:12:32 2026	(r1936261)
+++ httpd/httpd/trunk/modules/ssl/ssl_engine_kernel.c	Fri Jul 17 12:12:40 2026	(r1936262)
@@ -2238,7 +2238,7 @@ static apr_status_t set_challenge_creds(
 cleanup:
     if (our_data && cert) X509_free(cert);
     if (our_data && key) EVP_PKEY_free(key);
-    return APR_SUCCESS;
+    return rv;
 }
   
 /*