svn commit: r1936266 - httpd/httpd/trunk/modules/proxy

[email protected] Fri, 17 Jul 2026 13:58:04 -0000
Newsgroups gmane.comp.apache.cvs
Message-ID <178429668492.3866040.11708613724017452452@svn03-he-fi>
Author: jorton
Date: Fri Jul 17 13:58:04 2026
New Revision: 1936266

Log:
Use apr_isspace() instead of isspace() in cookie parsing

* modules/proxy/mod_proxy_balancer.c (find_session_route): Replace
  isspace() with apr_isspace() to avoid locale-dependent behavior
  and undefined behavior with negative char values.

Submitted by: arshsmith1 <arshi bugqore.com>
GitHub: closes #675

Modified:
   httpd/httpd/trunk/modules/proxy/mod_proxy_balancer.c

Modified: httpd/httpd/trunk/modules/proxy/mod_proxy_balancer.c
==============================================================================
--- httpd/httpd/trunk/modules/proxy/mod_proxy_balancer.c	Fri Jul 17 12:45:03 2026	(r1936265)
+++ httpd/httpd/trunk/modules/proxy/mod_proxy_balancer.c	Fri Jul 17 13:58:04 2026	(r1936266)
@@ -171,10 +171,10 @@ static char *get_cookie_param(request_re
             if (start_cookie == cookies ||
                 start_cookie[-1] == ';' ||
                 start_cookie[-1] == ',' ||
-                isspace(start_cookie[-1])) {
+                apr_isspace(start_cookie[-1])) {
 
                 start_cookie += strlen(name);
-                while(*start_cookie && isspace(*start_cookie))
+                while(*start_cookie && apr_isspace(*start_cookie))
                     ++start_cookie;
                 if (*start_cookie++ == '=' && *start_cookie) {
                     /*