Re: New failure in httpd units tests (xml related)
Joe Orton <[email protected]>
| Newsgroups | gmane.comp.apache.devel |
|---|---|
| Organization | Registered in England and Wales under Company Registration No. 03798903 Directors: Michael Cunningham (US), Michael O'Neill (Ireland), Paul Argiry (US) |
| Message-ID | <[email protected]> |
On Tue, May 06, 2025 at 03:09:05PM +0200, Rainer Jung wrote: > Hi there, > > I observed a new failure in httpd units tests, namely in t/apache/pr64339.t: > > # Failed test 12 in t/apache/pr64339.t at line 45 fail #4 > > # testing : content test for /doc.isohtml > # expected: '<html><body><p>fóó > # </p></body></html>' > # received: '<html><body>fóó > # </body></html>' > not ok 12 > > Note, that "<p>" and "</p>" are missing from the result. The test class > contains the following test definition: ... > The failure happens for 2.4.63 builds, although I didn't notice it during > the release vote. It is due to my update of libxml2 from 2.13.5 to 2.14.2. I > can reproduce the change with the accompanying xmllint: Thanks a lot for diagnosing it - does the attached pass for you with the new version of libxml2? Regards, Joe
pr64339t-fix.patch
(text/plain, 900 B)
Index: t/apache/pr64339.t
===================================================================
--- t/apache/pr64339.t (revision 1925434)
+++ t/apache/pr64339.t (working copy)
@@ -18,7 +18,7 @@
['/doc.notxml', "application/notreallyxml", "f\xf3\xf3\n" ],
# Sent with charset=ISO-8859-1 - should be transformed to utf-8
- ['/doc.isohtml', "text/html;charset=utf-8", "<html><body><p>fóó\n</p></body></html>" ],
+ ['/doc.isohtml', "text/html;charset=utf-8", "<html><body>.*fóó\n.*</body></html>" ],
);
# mod_xml2enc on trunk behaves quite differently to the 2.4.x version
@@ -42,5 +42,5 @@
ok t_cmp($r->code, 200, "fetching ".$t->[0]);
ok t_cmp($r->header('Content-Type'), $t->[1], "content-type header test for ".$t->[0]);
- ok t_cmp($r->content, $t->[2], "content test for ".$t->[0]);
+ ok t_cmp($r->content, qr/$t->[2]/, "content test for ".$t->[0]);
}