Re: Friendly nudge: PR #429 "mod_log_config: Add log_formatter support and a JSON log_formatter"

Ruediger Pluem <[email protected]>
Newsgroups gmane.comp.apache.devel
Message-ID <[email protected]>

On 7/29/25 6:00 PM, Thomas Meyer wrote:
> Hi,
> 
> although I was told this project is not dead, it doesn't feel that way...
> 
> how to get my PRs merged? I did receive no feedback after my last adjustments :-(

Sorry for the long silence and thanks for your reminder. I made some comments on the PR
regarding the actual code.
But if I think a bit further I think the current abstraction via the ap_log_formatted_data
callback is not flexible enough. Instead the provider API (see include/ap_provider.h) should
be used to enable an easy implementation of further providers in separate modules.
The standard rendering (rendering the format string as a string) and your json rendering could
then be implemented as such providers with the json provider moved into a separate module.
The provider implementing the standard rendering would be taken by default if no provider is specified.
This could add further value given the AP_ERRORLOG_PROVIDER_GROUP we have in trunk and which
allows more sophisticated log writer providers to be implemented that might like to get the data they
log in a more binary form.

Regards

Rüdiger
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.