Re: help needed: Windows CI broken
Jeff McKenna <[email protected]> Mon, 1 Jun 2026 13:37:15 -0300
| Newsgroups | gmane.comp.apache.devel |
|---|---|
| Message-ID | <[email protected]> |
On 2026-06-01 12:53 p.m., Jeff McKenna wrote:
> On 2026-06-01 12:39 p.m., Joe Orton wrote:
>> On Mon, Jun 01, 2026 at 12:24:14PM -0300, Jeff McKenna wrote:
>>> On 2026-06-01 9:54 a.m., Joe Orton wrote:
>>>> Windows builds have been failing in CI for a while, I think because of
>>>> some changes in the GHA images.
>>>>
>>>> I burnt some Claude tokens trying to fix the trunk to no avail [1], but
>>>> I have zero interest in this. It will be ... frustrating... if people
>>>> start voting against future 2.4.x rcs because Windows builds are broken
>>>> in some way which was trivial to catch in CI and fix ahead of time.
>>>>
>>>> Example trunk failure: https://github.com/apache/httpd/actions/
>>>> runs/25912053842/job/76159381743
>>>>
>>>> 2.4.x failure is "simpler" because of the cmake version mismatch:
>>>> https://github.com/apache/httpd/actions/runs/25488877019/
>>>> job/74791446628
>>>> but working around that as suggested did not help.
>>>>
>>>> Regards, Joe
>>>>
>>>> [1] https://github.com/notroj/httpd/tree/refs/heads/maybe-fix-
>>>> windows-ci
>>>
>>> Branch 2.4.x needs this change to be backported: https://github.com/
>>> apache/httpd/commit/08138ac986851217ff8f03b495d12ceca9051e24
>>
>> Does that definitely work? I tried -DCMAKE_POLICY_VERSION_MINIMUM=3.5
>> and it failed:
>> https://github.com/apache/httpd/actions/runs/26754488163/job/78850661003
>
> Ah! I didn't notice that attempt. To answer your question: yes that
> CMake change that I made works. The run that you pointed to you here
> makes it past that (thanks to that fix) and now breaks on a different
> issue.
>
> I had made a change locally to avoid that error: Unexpected enablement
> value "i" for mod_authnz_ldap
>
> But I wasn't proud of my workaround, and now I realize that I should
> create a pull request for my workaround for that "i" error (if I
> remember, I had to "unset(i)" outside of a for loop, to avoid that
> error. Will file a new pull request now (to the 2.4.x branch, if you
> already applied the other fix that I mentioned).
>
>>
>>> PS. Suggest to use the Backport action in the httpd repo (we use this
>>> and it
>>> works beautifully https://github.com/MapServer/MapServer/blob/
>>> main/.github/workflows/backport.yml
>>> )
>>
>> Sounds useful.... with writeable git ;)
>>
>>> Regarding trunk, there seems to be many changes in trunk that break the
>>> Windows MSVC compiler, it would take me a while to go through all of
>>> those
>>> changes (hmm I wonder why those changes made it through your CI
>>> tests / why
>>> they were merged before fixing the tests in Windows - as now it seems
>>> like a
>>> mountain of fixes are needed)
>>
>> I don't know or care about either cmake or Windows, so I don't have much
>> invested in this. The Windows CI started failing in early May and I'm
>> pretty sure it was not the relevant commit to trunk which triggered
>> that, but an image change:
>>
>> https://github.com/apache/httpd/actions/workflows/windows.yml?
>> query=branch%3Atrunk
>>
>> Regards, Joe
>>
New pull request (into branch 2.4.x) :
https://github.com/apache/httpd/pull/657
(backports earlier change, and also tackles the error :
Unexpected enablement value "i" for mod_authnz_ldap
thanks,
-jeff
--
Jeff McKenna
GatewayGeo: Developers of MS4W, & offering MapServer Consulting/Dev
co-founder of FOSS4G
http://gatewaygeo.com/