Re: help needed: Windows CI broken
Vladimir Chlup <[email protected]> Tue, 2 Jun 2026 09:19:37 +0200
| Newsgroups | gmane.comp.apache.devel |
|---|---|
| Message-ID | <CACQs4iy1ALthtYiU40-G53dMY7z8e5LMbWEC8cA9uKUr2ycO9Q@mail.gmail.com> |
--000000000000f8471a06534022a1 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hello, The issue is most likely caused by the change of the default GH Actions Windows image. See https://github.com/actions/runner-images/issues/14017 You can try using `windows-2022` instead of the current `windows-latest`. It should behave as before. Alternatively, I have prepared a PR with a fix here: https://github.com/apache/httpd/pull/659 Regards, Vladim=C3=ADr Chlup On Mon, Jun 1, 2026 at 6:45=E2=80=AFPM Jeff McKenna <jmckenna@gatewaygeomat= ics.com> wrote: > On 2026-06-01 12:53 p.m., Jeff McKenna wrote: > > On 2026-06-01 12:39 p.m., Joe Orton wrote: > >> On Mon, Jun 01, 2026 at 12:24:14PM -0300, Jeff McKenna wrote: > >>> On 2026-06-01 9:54 a.m., Joe Orton wrote: > >>>> Windows builds have been failing in CI for a while, I think because = of > >>>> some changes in the GHA images. > >>>> > >>>> I burnt some Claude tokens trying to fix the trunk to no avail [1], > but > >>>> I have zero interest in this. It will be ... frustrating... if peopl= e > >>>> start voting against future 2.4.x rcs because Windows builds are > broken > >>>> in some way which was trivial to catch in CI and fix ahead of time. > >>>> > >>>> Example trunk failure: https://github.com/apache/httpd/actions/ > >>>> runs/25912053842/job/76159381743 > >>>> > >>>> 2.4.x failure is "simpler" because of the cmake version mismatch: > >>>> https://github.com/apache/httpd/actions/runs/25488877019/ > >>>> job/74791446628 > >>>> but working around that as suggested did not help. > >>>> > >>>> Regards, Joe > >>>> > >>>> [1] https://github.com/notroj/httpd/tree/refs/heads/maybe-fix- > >>>> windows-ci > >>> > >>> Branch 2.4.x needs this change to be backported: https://github.com/ > >>> apache/httpd/commit/08138ac986851217ff8f03b495d12ceca9051e24 > >> > >> Does that definitely work? I tried -DCMAKE_POLICY_VERSION_MINIMUM=3D3.= 5 > >> and it failed: > >> > https://github.com/apache/httpd/actions/runs/26754488163/job/78850661003 > > > > Ah! I didn't notice that attempt. To answer your question: yes that > > CMake change that I made works. The run that you pointed to you here > > makes it past that (thanks to that fix) and now breaks on a different > > issue. > > > > I had made a change locally to avoid that error: Unexpected enablement > > value "i" for mod_authnz_ldap > > > > But I wasn't proud of my workaround, and now I realize that I should > > create a pull request for my workaround for that "i" error (if I > > remember, I had to "unset(i)" outside of a for loop, to avoid that > > error. Will file a new pull request now (to the 2.4.x branch, if you > > already applied the other fix that I mentioned). > > > >> > >>> PS. Suggest to use the Backport action in the httpd repo (we use this > >>> and it > >>> works beautifully https://github.com/MapServer/MapServer/blob/ > >>> main/.github/workflows/backport.yml > >>> ) > >> > >> Sounds useful.... with writeable git ;) > >> > >>> Regarding trunk, there seems to be many changes in trunk that break t= he > >>> Windows MSVC compiler, it would take me a while to go through all of > >>> those > >>> changes (hmm I wonder why those changes made it through your CI > >>> tests / why > >>> they were merged before fixing the tests in Windows - as now it seems > >>> like a > >>> mountain of fixes are needed) > >> > >> I don't know or care about either cmake or Windows, so I don't have mu= ch > >> invested in this. The Windows CI started failing in early May and I'm > >> pretty sure it was not the relevant commit to trunk which triggered > >> that, but an image change: > >> > >> https://github.com/apache/httpd/actions/workflows/windows.yml? > >> query=3Dbranch%3Atrunk > >> > >> Regards, Joe > >> > > New pull request (into branch 2.4.x) : > https://github.com/apache/httpd/pull/657 > > (backports earlier change, and also tackles the error : > Unexpected enablement value "i" for mod_authnz_ldap > > > thanks, > > -jeff > > > > -- > Jeff McKenna > GatewayGeo: Developers of MS4W, & offering MapServer Consulting/Dev > co-founder of FOSS4G > http://gatewaygeo.com/ > > --000000000000f8471a06534022a1 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"ltr"><div>Hello,</div><div><br></div><div>The issue is most lik= ely caused by the change of the default GH Actions Windows image. See=C2=A0= <a href=3D"https://github.com/actions/runner-images/issues/14017">https://g= ithub.com/actions/runner-images/issues/14017</a> You can try using `windows= -2022` instead of the current `windows-latest`. It should behave as before.= </div><div><br></div><div>Alternatively, I have prepared a PR with a fix he= re:=C2=A0<a href=3D"https://github.com/apache/httpd/pull/659">https://githu= b.com/apache/httpd/pull/659</a></div><div><br></div><div>Regards,</div><div= >Vladim=C3=ADr Chlup</div><div><br></div></div><br><div class=3D"gmail_quot= e gmail_quote_container"><div dir=3D"ltr" class=3D"gmail_attr">On Mon, Jun = 1, 2026 at 6:45=E2=80=AFPM Jeff McKenna <<a href=3D"mailto:jmckenna@gate= waygeomatics.com">[email protected]</a>> wrote:<br></div><bl= ockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-lef= t:1px solid rgb(204,204,204);padding-left:1ex">On 2026-06-01 12:53 p.m., Je= ff McKenna wrote:<br> > On 2026-06-01 12:39 p.m., Joe Orton wrote:<br> >> On Mon, Jun 01, 2026 at 12:24:14PM -0300, Jeff McKenna wrote:<br> >>> On 2026-06-01 9:54 a.m., Joe Orton wrote:<br> >>>> Windows builds have been failing in CI for a while, I thin= k because of<br> >>>> some changes in the GHA images.<br> >>>><br> >>>> I burnt some Claude tokens trying to fix the trunk to no a= vail [1], but<br> >>>> I have zero interest in this. It will be ... frustrating..= . if people<br> >>>> start voting against future 2.4.x rcs because Windows buil= ds are broken<br> >>>> in some way which was trivial to catch in CI and fix ahead= of time.<br> >>>><br> >>>> Example trunk failure: <a href=3D"https://github.com/apach= e/httpd/actions/" rel=3D"noreferrer" target=3D"_blank">https://github.com/a= pache/httpd/actions/</a> <br> >>>> runs/25912053842/job/76159381743<br> >>>><br> >>>> 2.4.x failure is "simpler" because of the cmake = version mismatch:<br> >>>> <a href=3D"https://github.com/apache/httpd/actions/runs/25= 488877019/" rel=3D"noreferrer" target=3D"_blank">https://github.com/apache/= httpd/actions/runs/25488877019/</a> <br> >>>> job/74791446628<br> >>>> but working around that as suggested did not help.<br> >>>><br> >>>> Regards, Joe<br> >>>><br> >>>> [1] <a href=3D"https://github.com/notroj/httpd/tree/refs/h= eads/maybe-fix-" rel=3D"noreferrer" target=3D"_blank">https://github.com/no= troj/httpd/tree/refs/heads/maybe-fix-</a> <br> >>>> windows-ci<br> >>><br> >>> Branch 2.4.x needs this change to be backported: <a href=3D"ht= tps://github.com/" rel=3D"noreferrer" target=3D"_blank">https://github.com/= </a> <br> >>> apache/httpd/commit/08138ac986851217ff8f03b495d12ceca9051e24<b= r> >><br> >> Does that definitely work? I tried -DCMAKE_POLICY_VERSION_MINIMUM= =3D3.5<br> >> and it failed:<br> >> <a href=3D"https://github.com/apache/httpd/actions/runs/2675448816= 3/job/78850661003" rel=3D"noreferrer" target=3D"_blank">https://github.com/= apache/httpd/actions/runs/26754488163/job/78850661003</a><br> > <br> > Ah!=C2=A0 I didn't notice that attempt.=C2=A0 To answer your quest= ion: yes that <br> > CMake change that I made works.=C2=A0 The run that you pointed to you = here <br> > makes it past that (thanks to that fix) and now breaks on a different = <br> > issue.<br> > <br> > I had made a change locally to avoid that error: Unexpected enablement= <br> > value "i" for mod_authnz_ldap<br> > <br> > But I wasn't proud of my workaround, and now I realize that I shou= ld <br> > create a pull request for my workaround for that "i" error (= if I <br> > remember, I had to "unset(i)" outside of a for loop, to avoi= d that <br> > error.=C2=A0 Will file a new pull request now (to the 2.4.x branch, if= you <br> > already applied the other fix that I mentioned).<br> > <br> >><br> >>> PS. Suggest to use the Backport action in the httpd repo (we u= se this <br> >>> and it<br> >>> works beautifully <a href=3D"https://github.com/MapServer/MapS= erver/blob/" rel=3D"noreferrer" target=3D"_blank">https://github.com/MapSer= ver/MapServer/blob/</a> <br> >>> main/.github/workflows/backport.yml<br> >>> )<br> >><br> >> Sounds useful.... with writeable git ;)<br> >><br> >>> Regarding trunk, there seems to be many changes in trunk that = break the<br> >>> Windows MSVC compiler, it would take me a while to go through = all of <br> >>> those<br> >>> changes (hmm I wonder why those changes made it through your C= I <br> >>> tests / why<br> >>> they were merged before fixing the tests in Windows - as now i= t seems <br> >>> like a<br> >>> mountain of fixes are needed)<br> >><br> >> I don't know or care about either cmake or Windows, so I don&#= 39;t have much<br> >> invested in this. The Windows CI started failing in early May and = I'm<br> >> pretty sure it was not the relevant commit to trunk which triggere= d<br> >> that, but an image change:<br> >><br> >> <a href=3D"https://github.com/apache/httpd/actions/workflows/windo= ws.yml" rel=3D"noreferrer" target=3D"_blank">https://github.com/apache/http= d/actions/workflows/windows.yml</a>? <br> >> query=3Dbranch%3Atrunk<br> >><br> >> Regards, Joe<br> >><br> <br> New pull request (into branch 2.4.x) : <br> <a href=3D"https://github.com/apache/httpd/pull/657" rel=3D"noreferrer" tar= get=3D"_blank">https://github.com/apache/httpd/pull/657</a><br> <br> (backports earlier change, and also tackles the error :<br> =C2=A0 =C2=A0 =C2=A0Unexpected enablement value "i" for mod_authn= z_ldap<br> <br> <br> thanks,<br> <br> -jeff<br> <br> <br> <br> -- <br> Jeff McKenna<br> GatewayGeo: Developers of MS4W, & offering MapServer Consulting/Dev<br> co-founder of FOSS4G<br> <a href=3D"http://gatewaygeo.com/" rel=3D"noreferrer" target=3D"_blank">htt= p://gatewaygeo.com/</a><br> <br> </blockquote></div> --000000000000f8471a06534022a1--