Re: help needed: Windows CI broken
Vladimir Chlup <[email protected]> Tue, 2 Jun 2026 17:42:46 +0200
| Newsgroups | gmane.comp.apache.devel |
|---|---|
| Message-ID | <CACQs4iyagvJAPuYfKCtjh2ebrJT6wnscAjPTv2o0FpXKRkCnYQ@mail.gmail.com> |
--0000000000005600e80653472a22 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable I agree that there seems to be a bit of a mixup, however, I don't think either of these two changes is necessarily required. See this: https://github.com/jajik/httpd/actions/runs/26829154521/. It's 2.4.x running with VS 2022.* Is it possible you have a CMake setting that treats warnings as errors? (like https://cmake.org/cmake/help/latest/variable/CMAKE_ERROR_DEPRECATED.html) Which version of CMake do you have? We might be missing something else... Best, Vlad * The reason it works without the trunk fix is that in my fork `windows-latest` is still the old container with VS 2022 while apache/httpd was already moved to the new image with VS 2026. On Tue, Jun 2, 2026 at 4:46=E2=80=AFPM Jeff McKenna <jmckenna@gatewaygeomat= ics.com> wrote: > On 2026-06-02 10:45 a.m., Paul Lodge wrote: > > Hi All, > > > > It might be in the best interest to move forward with Vlads suggestion > > for now and update the CMAKE_MINIMUM_REQUIRED but I'd leave the 'i' > > variable unset, as it's not an optimal solution it's ok as a quick fix > > but could potentially cause headaches in the future. > > > > I think that the Windows side of things in general (CMake, tests etc) > > need a little TLC, I don't mind looking into and taking on the task. > > > > Best > > > > Paul > > Joe seemed stressed about needing a workaround to get that branch 2.4.x > running, and I provided the workaround. > > I actually agree not to commit the 'unset(i)', notice that I submitted > the CMAKE_MINIMUM_REQUIRED change a month ago to trunk, as I figured > that my unset(i) change was not optimal. (however, to this day, I need > that unset(i) to get branch 2.4.x to compile, as mentioned by Joe in his > GitHub run). > > /me just trying to help > > Sorry all, > > -jeff > > > > > > > > > > On 02/06/2026 09:19, Vladimir Chlup wrote: > >> Hello, > >> > >> The issue is most likely caused by the change of the default GH > >> Actions Windows image. See https://github.com/actions/runner-images/ > >> issues/14017 You can try using `windows-2022` instead of the current > >> `windows-latest`. It should behave as before. > >> > >> Alternatively, I have prepared a PR with a fix here: https:// > >> github.com/apache/httpd/pull/659 > >> > >> Regards, > >> Vladim=C3=ADr Chlup > >> > >> > >> On Mon, Jun 1, 2026 at 6:45=E2=80=AFPM Jeff McKenna > >> <[email protected]> wrote: > >> > >> On 2026-06-01 12:53 p.m., Jeff McKenna wrote: > >> > On 2026-06-01 12:39 p.m., Joe Orton wrote: > >> >> On Mon, Jun 01, 2026 at 12:24:14PM -0300, Jeff McKenna wrote: > >> >>> On 2026-06-01 9:54 a.m., Joe Orton wrote: > >> >>>> Windows builds have been failing in CI for a while, I think > >> because of > >> >>>> some changes in the GHA images. > >> >>>> > >> >>>> I burnt some Claude tokens trying to fix the trunk to no > >> avail [1], but > >> >>>> I have zero interest in this. It will be ... frustrating... > >> if people > >> >>>> start voting against future 2.4.x rcs because Windows builds > >> are broken > >> >>>> in some way which was trivial to catch in CI and fix ahead of > >> time. > >> >>>> > >> >>>> Example trunk failure: > https://github.com/apache/httpd/actions/ > >> >>>> runs/25912053842/job/76159381743 > >> >>>> > >> >>>> 2.4.x failure is "simpler" because of the cmake version > mismatch: > >> >>>> https://github.com/apache/httpd/actions/runs/25488877019/ > >> >>>> job/74791446628 > >> >>>> but working around that as suggested did not help. > >> >>>> > >> >>>> Regards, Joe > >> >>>> > >> >>>> [1] https://github.com/notroj/httpd/tree/refs/heads/maybe-fix= - > >> >>>> windows-ci > >> >>> > >> >>> Branch 2.4.x needs this change to be backported: https:// > >> github.com/ > >> >>> apache/httpd/commit/08138ac986851217ff8f03b495d12ceca9051e24 > >> >> > >> >> Does that definitely work? I tried - > >> DCMAKE_POLICY_VERSION_MINIMUM=3D3.5 > >> >> and it failed: > >> >> https://github.com/apache/httpd/actions/runs/26754488163/ > >> job/78850661003 > >> > > >> > Ah! I didn't notice that attempt. To answer your question: yes > >> that > >> > CMake change that I made works. The run that you pointed to you > >> here > >> > makes it past that (thanks to that fix) and now breaks on a > >> different > >> > issue. > >> > > >> > I had made a change locally to avoid that error: Unexpected > >> enablement > >> > value "i" for mod_authnz_ldap > >> > > >> > But I wasn't proud of my workaround, and now I realize that I > >> should > >> > create a pull request for my workaround for that "i" error (if I > >> > remember, I had to "unset(i)" outside of a for loop, to avoid th= at > >> > error. Will file a new pull request now (to the 2.4.x branch, > >> if you > >> > already applied the other fix that I mentioned). > >> > > >> >> > >> >>> PS. Suggest to use the Backport action in the httpd repo (we > >> use this > >> >>> and it > >> >>> works beautifully https://github.com/MapServer/MapServer/blob/ > >> >>> main/.github/workflows/backport.yml > >> >>> ) > >> >> > >> >> Sounds useful.... with writeable git ;) > >> >> > >> >>> Regarding trunk, there seems to be many changes in trunk that > >> break the > >> >>> Windows MSVC compiler, it would take me a while to go through > >> all of > >> >>> those > >> >>> changes (hmm I wonder why those changes made it through your C= I > >> >>> tests / why > >> >>> they were merged before fixing the tests in Windows - as now > >> it seems > >> >>> like a > >> >>> mountain of fixes are needed) > >> >> > >> >> I don't know or care about either cmake or Windows, so I don't > >> have much > >> >> invested in this. The Windows CI started failing in early May > >> and I'm > >> >> pretty sure it was not the relevant commit to trunk which > triggered > >> >> that, but an image change: > >> >> > >> >> https://github.com/apache/httpd/actions/workflows/windows.yml? > >> >> query=3Dbranch%3Atrunk > >> >> > >> >> Regards, Joe > >> >> > >> > >> New pull request (into branch 2.4.x) : > >> https://github.com/apache/httpd/pull/657 > >> > >> (backports earlier change, and also tackles the error : > >> Unexpected enablement value "i" for mod_authnz_ldap > >> > >> > >> thanks, > >> > >> -jeff > >> > >> > >> > >> -- > >> Jeff McKenna > >> GatewayGeo: Developers of MS4W, & offering MapServer Consulting/De= v > >> co-founder of FOSS4G > >> http://gatewaygeo.com/ > >> > > > -- > Jeff McKenna > GatewayGeo: Developers of MS4W, & offering MapServer Consulting/Dev > co-founder of FOSS4G > http://gatewaygeo.com/ > > --0000000000005600e80653472a22 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"ltr"><div>I agree that there seems to be a bit of a mixup, howe= ver, I don't think either of these two changes is necessarily required.= </div><div><br></div><div>See this:=C2=A0<a href=3D"https://github.com/jaji= k/httpd/actions/runs/26829154521/">https://github.com/jajik/httpd/actions/r= uns/26829154521/</a>. It's 2.4.x=C2=A0running with VS 2022.*</div><div>= <br></div><div>Is it possible you have a=C2=A0CMake setting that treats war= nings as errors? (like=C2=A0<a href=3D"https://cmake.org/cmake/help/latest/= variable/CMAKE_ERROR_DEPRECATED.html">https://cmake.org/cmake/help/latest/v= ariable/CMAKE_ERROR_DEPRECATED.html</a>) Which version of CMake do you have= ? We might be missing something else...</div><div><br></div><div>Best,</div= ><div>Vlad</div><div><br></div><div>* The reason it works without=C2=A0the = trunk fix is=C2=A0that in my fork `windows-latest` is still the old contain= er with VS 2022 while apache/httpd was already moved to the new image with = VS 2026.</div><div><br></div></div><br><div class=3D"gmail_quote gmail_quot= e_container"><div dir=3D"ltr" class=3D"gmail_attr">On Tue, Jun 2, 2026 at 4= :46=E2=80=AFPM Jeff McKenna <<a href=3D"mailto:jmckenna@gatewaygeomatics= .com">[email protected]</a>> wrote:<br></div><blockquote cla= ss=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid = rgb(204,204,204);padding-left:1ex">On 2026-06-02 10:45 a.m., Paul Lodge wro= te:<br> > Hi All,<br> > <br> > It might be in the best interest to move forward with Vlads suggestion= <br> > for now and update the CMAKE_MINIMUM_REQUIRED but I'd leave the &#= 39;i' <br> > variable unset, as it's not an optimal solution it's ok as a q= uick fix <br> > but could=C2=A0potentially=C2=A0cause headaches in the future.<br> > <br> > I think that the Windows side of things in general (CMake, tests etc) = <br> > need a little TLC, I don't mind looking into and taking on the tas= k.<br> > <br> > Best<br> > <br> > Paul<br> <br> Joe seemed stressed about needing a workaround to get that branch 2.4.x <br= > running, and I provided the workaround.<br> <br> I actually agree not to commit the 'unset(i)', notice that I submit= ted <br> the CMAKE_MINIMUM_REQUIRED change a month ago to trunk, as I figured <br> that my unset(i) change was not optimal.=C2=A0 (however, to this day, I nee= d <br> that unset(i) to get branch 2.4.x to compile, as mentioned by Joe in his <b= r> GitHub run).<br> <br> /me just trying to help<br> <br> Sorry all,<br> <br> -jeff<br> <br> <br> <br> <br> > <br> > <br> > On 02/06/2026 09:19, Vladimir Chlup wrote:<br> >> Hello,<br> >><br> >> The issue is most likely caused by the change of the default GH <b= r> >> Actions Windows image. See <a href=3D"https://github.com/actions/r= unner-images/" rel=3D"noreferrer" target=3D"_blank">https://github.com/acti= ons/runner-images/</a> <br> >> issues/14017 You can try using `windows-2022` instead of the curre= nt <br> >> `windows-latest`. It should behave as before.<br> >><br> >> Alternatively, I have prepared a PR with a fix here: https:// <br> >> <a href=3D"http://github.com/apache/httpd/pull/659" rel=3D"norefer= rer" target=3D"_blank">github.com/apache/httpd/pull/659</a><br> >><br> >> Regards,<br> >> Vladim=C3=ADr Chlup<br> >><br> >><br> >> On Mon, Jun 1, 2026 at 6:45=E2=80=AFPM Jeff McKenna <br> >> <<a href=3D"mailto:[email protected]" target=3D"_bl= ank">[email protected]</a>> wrote:<br> >><br> >>=C2=A0 =C2=A0 =C2=A0On 2026-06-01 12:53 p.m., Jeff McKenna wrote:<b= r> >>=C2=A0 =C2=A0 =C2=A0> On 2026-06-01 12:39 p.m., Joe Orton wrote:= <br> >>=C2=A0 =C2=A0 =C2=A0>> On Mon, Jun 01, 2026 at 12:24:14PM -03= 00, Jeff McKenna wrote:<br> >>=C2=A0 =C2=A0 =C2=A0>>> On 2026-06-01 9:54 a.m., Joe Orton= wrote:<br> >>=C2=A0 =C2=A0 =C2=A0>>>> Windows builds have been faili= ng in CI for a while, I think<br> >>=C2=A0 =C2=A0 =C2=A0because of<br> >>=C2=A0 =C2=A0 =C2=A0>>>> some changes in the GHA images= .<br> >>=C2=A0 =C2=A0 =C2=A0>>>><br> >>=C2=A0 =C2=A0 =C2=A0>>>> I burnt some Claude tokens try= ing to fix the trunk to no<br> >>=C2=A0 =C2=A0 =C2=A0avail [1], but<br> >>=C2=A0 =C2=A0 =C2=A0>>>> I have zero interest in this. = It will be ... frustrating...<br> >>=C2=A0 =C2=A0 =C2=A0if people<br> >>=C2=A0 =C2=A0 =C2=A0>>>> start voting against future 2.= 4.x rcs because Windows builds<br> >>=C2=A0 =C2=A0 =C2=A0are broken<br> >>=C2=A0 =C2=A0 =C2=A0>>>> in some way which was trivial = to catch in CI and fix ahead of<br> >>=C2=A0 =C2=A0 =C2=A0time.<br> >>=C2=A0 =C2=A0 =C2=A0>>>><br> >>=C2=A0 =C2=A0 =C2=A0>>>> Example trunk failure: <a href= =3D"https://github.com/apache/httpd/actions/" rel=3D"noreferrer" target=3D"= _blank">https://github.com/apache/httpd/actions/</a><br> >>=C2=A0 =C2=A0 =C2=A0>>>> runs/25912053842/job/761593817= 43<br> >>=C2=A0 =C2=A0 =C2=A0>>>><br> >>=C2=A0 =C2=A0 =C2=A0>>>> 2.4.x failure is "simpler= " because of the cmake version mismatch:<br> >>=C2=A0 =C2=A0 =C2=A0>>>> <a href=3D"https://github.com/= apache/httpd/actions/runs/25488877019/" rel=3D"noreferrer" target=3D"_blank= ">https://github.com/apache/httpd/actions/runs/25488877019/</a><br> >>=C2=A0 =C2=A0 =C2=A0>>>> job/74791446628<br> >>=C2=A0 =C2=A0 =C2=A0>>>> but working around that as sug= gested did not help.<br> >>=C2=A0 =C2=A0 =C2=A0>>>><br> >>=C2=A0 =C2=A0 =C2=A0>>>> Regards, Joe<br> >>=C2=A0 =C2=A0 =C2=A0>>>><br> >>=C2=A0 =C2=A0 =C2=A0>>>> [1] <a href=3D"https://github.= com/notroj/httpd/tree/refs/heads/maybe-fix-" rel=3D"noreferrer" target=3D"_= blank">https://github.com/notroj/httpd/tree/refs/heads/maybe-fix-</a><br> >>=C2=A0 =C2=A0 =C2=A0>>>> windows-ci<br> >>=C2=A0 =C2=A0 =C2=A0>>><br> >>=C2=A0 =C2=A0 =C2=A0>>> Branch 2.4.x needs this change to = be backported: https://<br> >>=C2=A0 =C2=A0 =C2=A0<a href=3D"http://github.com/" rel=3D"noreferre= r" target=3D"_blank">github.com/</a><br> >>=C2=A0 =C2=A0 =C2=A0>>> apache/httpd/commit/08138ac9868512= 17ff8f03b495d12ceca9051e24<br> >>=C2=A0 =C2=A0 =C2=A0>><br> >>=C2=A0 =C2=A0 =C2=A0>> Does that definitely work? I tried -<b= r> >>=C2=A0 =C2=A0 =C2=A0DCMAKE_POLICY_VERSION_MINIMUM=3D3.5<br> >>=C2=A0 =C2=A0 =C2=A0>> and it failed:<br> >>=C2=A0 =C2=A0 =C2=A0>> <a href=3D"https://github.com/apache/h= ttpd/actions/runs/26754488163/" rel=3D"noreferrer" target=3D"_blank">https:= //github.com/apache/httpd/actions/runs/26754488163/</a><br> >>=C2=A0 =C2=A0 =C2=A0job/78850661003<br> >>=C2=A0 =C2=A0 =C2=A0><br> >>=C2=A0 =C2=A0 =C2=A0> Ah!=C2=A0 I didn't notice that attempt= .=C2=A0 To answer your question: yes<br> >>=C2=A0 =C2=A0 =C2=A0that<br> >>=C2=A0 =C2=A0 =C2=A0> CMake change that I made works.=C2=A0 The = run that you pointed to you<br> >>=C2=A0 =C2=A0 =C2=A0here<br> >>=C2=A0 =C2=A0 =C2=A0> makes it past that (thanks to that fix) an= d now breaks on a<br> >>=C2=A0 =C2=A0 =C2=A0different<br> >>=C2=A0 =C2=A0 =C2=A0> issue.<br> >>=C2=A0 =C2=A0 =C2=A0><br> >>=C2=A0 =C2=A0 =C2=A0> I had made a change locally to avoid that = error: Unexpected<br> >>=C2=A0 =C2=A0 =C2=A0enablement<br> >>=C2=A0 =C2=A0 =C2=A0> value "i" for mod_authnz_ldap<br= > >>=C2=A0 =C2=A0 =C2=A0><br> >>=C2=A0 =C2=A0 =C2=A0> But I wasn't proud of my workaround, a= nd now I realize that I<br> >>=C2=A0 =C2=A0 =C2=A0should<br> >>=C2=A0 =C2=A0 =C2=A0> create a pull request for my workaround fo= r that "i" error (if I<br> >>=C2=A0 =C2=A0 =C2=A0> remember, I had to "unset(i)" ou= tside of a for loop, to avoid that<br> >>=C2=A0 =C2=A0 =C2=A0> error.=C2=A0 Will file a new pull request = now (to the 2.4.x branch,<br> >>=C2=A0 =C2=A0 =C2=A0if you<br> >>=C2=A0 =C2=A0 =C2=A0> already applied the other fix that I menti= oned).<br> >>=C2=A0 =C2=A0 =C2=A0><br> >>=C2=A0 =C2=A0 =C2=A0>><br> >>=C2=A0 =C2=A0 =C2=A0>>> PS. Suggest to use the Backport ac= tion in the httpd repo (we<br> >>=C2=A0 =C2=A0 =C2=A0use this<br> >>=C2=A0 =C2=A0 =C2=A0>>> and it<br> >>=C2=A0 =C2=A0 =C2=A0>>> works beautifully <a href=3D"https= ://github.com/MapServer/MapServer/blob/" rel=3D"noreferrer" target=3D"_blan= k">https://github.com/MapServer/MapServer/blob/</a><br> >>=C2=A0 =C2=A0 =C2=A0>>> main/.github/workflows/backport.ym= l<br> >>=C2=A0 =C2=A0 =C2=A0>>> )<br> >>=C2=A0 =C2=A0 =C2=A0>><br> >>=C2=A0 =C2=A0 =C2=A0>> Sounds useful.... with writeable git ;= )<br> >>=C2=A0 =C2=A0 =C2=A0>><br> >>=C2=A0 =C2=A0 =C2=A0>>> Regarding trunk, there seems to be= many changes in trunk that<br> >>=C2=A0 =C2=A0 =C2=A0break the<br> >>=C2=A0 =C2=A0 =C2=A0>>> Windows MSVC compiler, it would ta= ke me a while to go through<br> >>=C2=A0 =C2=A0 =C2=A0all of<br> >>=C2=A0 =C2=A0 =C2=A0>>> those<br> >>=C2=A0 =C2=A0 =C2=A0>>> changes (hmm I wonder why those ch= anges made it through your CI<br> >>=C2=A0 =C2=A0 =C2=A0>>> tests / why<br> >>=C2=A0 =C2=A0 =C2=A0>>> they were merged before fixing the= tests in Windows - as now<br> >>=C2=A0 =C2=A0 =C2=A0it seems<br> >>=C2=A0 =C2=A0 =C2=A0>>> like a<br> >>=C2=A0 =C2=A0 =C2=A0>>> mountain of fixes are needed)<br> >>=C2=A0 =C2=A0 =C2=A0>><br> >>=C2=A0 =C2=A0 =C2=A0>> I don't know or care about either = cmake or Windows, so I don't<br> >>=C2=A0 =C2=A0 =C2=A0have much<br> >>=C2=A0 =C2=A0 =C2=A0>> invested in this. The Windows CI start= ed failing in early May<br> >>=C2=A0 =C2=A0 =C2=A0and I'm<br> >>=C2=A0 =C2=A0 =C2=A0>> pretty sure it was not the relevant co= mmit to trunk which triggered<br> >>=C2=A0 =C2=A0 =C2=A0>> that, but an image change:<br> >>=C2=A0 =C2=A0 =C2=A0>><br> >>=C2=A0 =C2=A0 =C2=A0>> <a href=3D"https://github.com/apache/h= ttpd/actions/workflows/windows.yml" rel=3D"noreferrer" target=3D"_blank">ht= tps://github.com/apache/httpd/actions/workflows/windows.yml</a>?<br> >>=C2=A0 =C2=A0 =C2=A0>> query=3Dbranch%3Atrunk<br> >>=C2=A0 =C2=A0 =C2=A0>><br> >>=C2=A0 =C2=A0 =C2=A0>> Regards, Joe<br> >>=C2=A0 =C2=A0 =C2=A0>><br> >><br> >>=C2=A0 =C2=A0 =C2=A0New pull request (into branch 2.4.x) :<br> >>=C2=A0 =C2=A0 =C2=A0<a href=3D"https://github.com/apache/httpd/pull= /657" rel=3D"noreferrer" target=3D"_blank">https://github.com/apache/httpd/= pull/657</a><br> >><br> >>=C2=A0 =C2=A0 =C2=A0(backports earlier change, and also tackles the= error :<br> >>=C2=A0 =C2=A0 =C2=A0=C2=A0 =C2=A0 =C2=A0Unexpected enablement value= "i" for mod_authnz_ldap<br> >><br> >><br> >>=C2=A0 =C2=A0 =C2=A0thanks,<br> >><br> >>=C2=A0 =C2=A0 =C2=A0-jeff<br> >><br> >><br> >><br> >>=C2=A0 =C2=A0 =C2=A0-- <br> >>=C2=A0 =C2=A0 =C2=A0Jeff McKenna<br> >>=C2=A0 =C2=A0 =C2=A0GatewayGeo: Developers of MS4W, & offering = MapServer Consulting/Dev<br> >>=C2=A0 =C2=A0 =C2=A0co-founder of FOSS4G<br> >>=C2=A0 =C2=A0 =C2=A0<a href=3D"http://gatewaygeo.com/" rel=3D"noref= errer" target=3D"_blank">http://gatewaygeo.com/</a><br> >><br> <br> <br> -- <br> Jeff McKenna<br> GatewayGeo: Developers of MS4W, & offering MapServer Consulting/Dev<br> co-founder of FOSS4G<br> <a href=3D"http://gatewaygeo.com/" rel=3D"noreferrer" target=3D"_blank">htt= p://gatewaygeo.com/</a><br> <br> </blockquote></div> --0000000000005600e80653472a22--