Re: svn commit: r1158546 - in /logging/chainsaw/trunk/src/main/java/org/apache/log4j/chainsaw: LogFilePatternLayoutBuilder.java LogUI.java vfs/VFSLogFilePatternReceiver.java

Stefan Bodewig <[email protected]> Wed, 17 Aug 2011 09:26:27 +0200

Newsgroups	gmane.comp.apache.logging
Message-ID	<[email protected]>

Hi Scott,

I don't know why commit mails go to the general list, but this one
caught my eye:

On 2011-08-17, <[email protected]> wrote:

>                  Node fileNameNode = appenderChild.getAttributes().getNamedItem("name");
> -                if (fileNameNode != null && fileNameNode.getNodeValue().equals("file")) {
> +                If (fileNameNode != null && fileNameNode.getNodeValue().toLowerCase().equals("file")) {

this is a locale sensitive comparison which is likely to cause problems
in the famous Turkish/Azeri locale case ("I".toLowerCase() != "i"
there).

You may want to use fileNameNode.getNodeValue().equalsIgnoreCase("file")
instead, which is safe.

Stefan