utility.c and ap_set_last_modified()

Jim Kane <[email protected]> Wed, 28 Apr 2004 12:02:59 -0500
Newsgroups gmane.comp.apache.mod-layout
Message-ID <[email protected]>
While browsing through the mod_layout source, I noticed the following at 
line 600 of utility.c:
    ap_update_mtime(r, r->finfo.st_mtime);
/*    ap_set_last_modified(r);*/

The second line shown above was commented out in May of 2001 (see CVS 
1.41 -> 1.42).  The strange part is, from what I could find in the 
Apache API docs, the first line doesn't do much without the second line 
(i.e. it does not set the Last-Modified: header).  This would confirm 
what we have found here, namely that putting the header on a static page 
renders it uncacheable by removing several important headers such as 
Last-Modified and Content-Length.  I have seen several patches on the 
list that uncomment this line, so I tried it last night -- and it seemed 
to work OK with the static test docs I used.  Can anyone fill me in on 
why it was taken out?

-- 
Jim Kane <[email protected]> | 501-324-8900 | http://www.arkansas.gov/
Systems Manager | Information Network of Arkansas | 877-7AR-EGOV