Re: Mod_layout 3.2.1 segfaults on Mac OS X and Sparc with DEBUG enabled

On Thu, 2007-03-22 at 15:23 -0700, Brian Aker wrote:
> Hi!
> 
> Perfect! I found it and fixed it. You will need to grab a copy via  
> http://hg.tangent.org/mod_layout-3.0?ca=tip;type=gz
> 
> Can you confirm for me that it works? If so I will roll out a new  
> release.

Good news! This version fixes the bug on Solaris (not tested in Mac OS
X). Note that I had to append -DDEBUG in Makefile, because you removed
in this version. Well,  it works, good.

Another suggestion is to make use of $(APXS) instead of calling apxs,
like this:

--- Makefile.orig       2007-03-23 15:01:16.000000000 -0300
+++ Makefile    2007-03-23 15:01:33.000000000 -0300
@@ -5,9 +5,9 @@
 #   the used tools
 APXS=apxs
 APACHECTL=apachectl
-CC=`apxs -q CC`
-INC=-I`apxs -q INCLUDEDIR` `$(APXS) -q CFLAGS`
#-DLAYOUT_FILEOWNER_NAME
-LD_SHLIB=`apxs -q LDFLAGS_SHLIB`
+CC=`$(APXS) -q CC`
+INC=-I`$(APXS) -q INCLUDEDIR` `$(APXS) -q CFLAGS`
#-DLAYOUT_FILEOWNER_NAME
+LD_SHLIB=`$(APXS) -q LDFLAGS_SHLIB`
 VERSION = 3.3
 DISTNAME = mod_layout
 DISTVNAME = $(DISTNAME)-$(VERSION)


In the same way as the higher versions of mod_layout.
Thank you!

-- 
Rudá Moura <[email protected]>
Terra Networks Brasil S.A. +55 51 3284 9580