Re: [RELEASE CANDIDATE] Apache-Test-1.43 RC1

--000000000000dbde4305d006f8be
Content-Type: text/plain; charset="UTF-8"

On Fri, 5 Nov 2021 at 01:54, Edward J. Sabol <[email protected]> wrote:

> Anyway, these are pretty minor changes, but I don't think this change is
> quite correct:
>
> +    # No need to search PATH components
> +    # if $program already contains a path
> +    return $program if !OSX and !WINFU and
> +        $program =~ /\// and -f $program and -x $program;
> +
>
> OSX uses slashes for path separators and supports "-f" and "-x". I feel
> the "!OSX and " should be removed here, but I can't test it as all of my
> Apache httpd systems are on Linux.
>
>     return $program if !WINFU and
>         $program =~ /\// and -f $program and -x $program;
>
>

Unfortunately I can't test OSX either. Is anyone here able to?

The change in question is this:

https://svn.apache.org/viewvc?view=revision&revision=1880585

Rainer, did you include that "!OSX" for a specific reason? Do you know if
Ed is correct that it can be dropped as he suggests?

--000000000000dbde4305d006f8be
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr">On Fri, 5 Nov 2021 at 01:54, Edward J. Sa=
bol &lt;<a href=3D"mailto:[email protected]" target=3D"_blank">edwardj=
[email protected]</a>&gt; wrote:<br></div><div class=3D"gmail_quote"><blockqu=
ote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px=
 solid rgb(204,204,204);padding-left:1ex">Anyway, these are pretty minor ch=
anges, but I don&#39;t think this change is quite correct:<br>
<br>
+=C2=A0 =C2=A0 # No need to search PATH components<br>
+=C2=A0 =C2=A0 # if $program already contains a path<br>
+=C2=A0 =C2=A0 return $program if !OSX and !WINFU and<br>
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 $program =3D~ /\// and -f $program and -x $pro=
gram;<br>
+<br>
<br>
OSX uses slashes for path separators and supports &quot;-f&quot; and &quot;=
-x&quot;. I feel the &quot;!OSX and &quot; should be removed here, but I ca=
n&#39;t test it as all of my Apache httpd systems are on Linux.<br>
<br>
=C2=A0 =C2=A0 return $program if !WINFU and<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 $program =3D~ /\// and -f $program and -x $prog=
ram;<br>=C2=A0<br></blockquote><div><br></div><div>Unfortunately I can&#39;=
t test OSX either. Is anyone here able to?</div><div><br></div><div>The cha=
nge in question is this:</div><div><br></div><div><a href=3D"https://svn.ap=
ache.org/viewvc?view=3Drevision&amp;revision=3D1880585" target=3D"_blank">h=
ttps://svn.apache.org/viewvc?view=3Drevision&amp;revision=3D1880585</a></di=
v><div><br></div><div>Rainer, did you include that &quot;!OSX&quot; for a s=
pecific reason? Do you know if Ed is correct that it can be dropped as he s=
uggests?</div></div></div>

--000000000000dbde4305d006f8be--