Re: [RELEASE CANDIDATE] Apache-Test-1.43 RC1
Steve Hay <[email protected]> Fri, 5 Nov 2021 10:04:01 +0000
| Newsgroups | gmane.comp.apache.mod-perl.devel |
|---|---|
| Message-ID | <CADED=K4yh+gioi1uhw5qgN+Ginjb8PnHYkKaG8vb6PUfnP1TuA@mail.gmail.com> |
--000000000000ce651f05d007c3a8 Content-Type: text/plain; charset="UTF-8" On Fri, 5 Nov 2021 at 09:25, Rainer Jung <[email protected]> wrote: > Am 05.11.2021 um 10:07 schrieb Steve Hay: > > On Fri, 5 Nov 2021 at 01:54, Edward J. Sabol <[email protected] > > <mailto:[email protected]>> wrote: > > > > Anyway, these are pretty minor changes, but I don't think this > > change is quite correct: > > > > + # No need to search PATH components > > + # if $program already contains a path > > + return $program if !OSX and !WINFU and > > + $program =~ /\// and -f $program and -x $program; > > + > > > > OSX uses slashes for path separators and supports "-f" and "-x". I > > feel the "!OSX and " should be removed here, but I can't test it as > > all of my Apache httpd systems are on Linux. > > > > return $program if !WINFU and > > $program =~ /\// and -f $program and -x $program; > > > > > > Unfortunately I can't test OSX either. Is anyone here able to? > > > > The change in question is this: > > > > https://svn.apache.org/viewvc?view=revision&revision=1880585 > > <https://svn.apache.org/viewvc?view=revision&revision=1880585> > > > > Rainer, did you include that "!OSX" for a specific reason? Do you know > > if Ed is correct that it can be dropped as he suggests? > > I can't test OSX either and I think that was the only reason for the !OSX. > > Ok, thanks. I will wait a few more days in case anyone is able to test on OSX, but if not then I will go ahead and release this as-is, i.e. with the !OSX since it makes sense to retain it if nobody can test on that platform. --000000000000ce651f05d007c3a8 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"ltr"><div dir=3D"ltr">On Fri, 5 Nov 2021 at 09:25, Rainer Jung = <<a href=3D"mailto:[email protected]">[email protected]</a>&= gt; wrote:<br></div><div class=3D"gmail_quote"><blockquote class=3D"gmail_q= uote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,2= 04);padding-left:1ex">Am 05.11.2021 um 10:07 schrieb Steve Hay:<br> > On Fri, 5 Nov 2021 at 01:54, Edward J. Sabol <<a href=3D"mailto:edw= [email protected]" target=3D"_blank">[email protected]</a> <br> > <mailto:<a href=3D"mailto:[email protected]" target=3D"_blank"= >[email protected]</a>>> wrote:<br> > <br> >=C2=A0 =C2=A0 =C2=A0Anyway, these are pretty minor changes, but I don&#= 39;t think this<br> >=C2=A0 =C2=A0 =C2=A0change is quite correct:<br> > <br> >=C2=A0 =C2=A0 =C2=A0+=C2=A0 =C2=A0 # No need to search PATH components<= br> >=C2=A0 =C2=A0 =C2=A0+=C2=A0 =C2=A0 # if $program already contains a pat= h<br> >=C2=A0 =C2=A0 =C2=A0+=C2=A0 =C2=A0 return $program if !OSX and !WINFU a= nd<br> >=C2=A0 =C2=A0 =C2=A0+=C2=A0 =C2=A0 =C2=A0 =C2=A0 $program =3D~ /\// and= -f $program and -x $program;<br> >=C2=A0 =C2=A0 =C2=A0+<br> > <br> >=C2=A0 =C2=A0 =C2=A0OSX uses slashes for path separators and supports &= quot;-f" and "-x". I<br> >=C2=A0 =C2=A0 =C2=A0feel the "!OSX and " should be removed he= re, but I can't test it as<br> >=C2=A0 =C2=A0 =C2=A0all of my Apache httpd systems are on Linux.<br> > <br> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 return $program if !WINFU and<br> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 $program =3D~ /\// and= -f $program and -x $program;<br> > <br> > <br> > Unfortunately I can't test OSX either. Is anyone here able to?<br> > <br> > The change in question is this:<br> > <br> > <a href=3D"https://svn.apache.org/viewvc?view=3Drevision&revision= =3D1880585" rel=3D"noreferrer" target=3D"_blank">https://svn.apache.org/vie= wvc?view=3Drevision&revision=3D1880585</a> <br> > <<a href=3D"https://svn.apache.org/viewvc?view=3Drevision&revis= ion=3D1880585" rel=3D"noreferrer" target=3D"_blank">https://svn.apache.org/= viewvc?view=3Drevision&revision=3D1880585</a>><br> > <br> > Rainer, did you include that "!OSX" for a specific reason? D= o you know <br> > if Ed is correct that it can be dropped as he suggests?<br> <br> I can't test OSX either and I think that was the only reason for the !O= SX.<br>=C2=A0<br></blockquote><div><br></div><div>Ok, thanks.</div><div><br= ></div><div>I will wait a few more days in case anyone is able to test on O= SX, but if not then I will go ahead and release this as-is, i.e. with the != OSX=C2=A0since it makes sense to retain it if nobody can test on that platf= orm.</div></div></div> --000000000000ce651f05d007c3a8--