Re: [RELEASE CANDIDATE] Apache-SizeLimit 0.92 RC1

On Fri, Aug 6, 2010 at 11:16 AM, Philip M. Gollucci
<[email protected]> wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> On 08/06/10 12:52, Cosimo Streppone wrote:
>> On Wed, Aug 4, 2010 at 8:25 AM, Philip M. Gollucci
>> <[email protected]> wrote:
>>
>>> -----BEGIN PGP SIGNED MESSAGE-----
>>> Hash: SHA1
>>>
>>> http://people.apache.org/~pgollucci/Apache-SizeLimit-0.92-rc1.tar.gz
>>> http://people.apache.org/~pgollucci/Apache-SizeLimit-0.92-rc1.tar.gz.md5
>>> http://people.apache.org/~pgollucci/Apache-SizeLimit-0.92-rc1.tar.gz.sha256
>>>
>>> http://people.apache.org/~pgollucci/Apache-SizeLimit-0.92-rc1.tar.gz.asc
>>
>> Builds and tests fine both on Debian Lenny w/ Apache 2.2.9
>> and perl 5.10 and Ubuntu 10.04.
>>
>> I seem to understand that our current SizeLimit config (below) will
>> be completely bogus with the new version, right?
>
>>   # Will prevent murders of immature children that just needs to grow a bit
>>   $Apache2::SizeLimit::CHECK_EVERY_N_REQUESTS = 30;
>>
>>   $Apache2::SizeLimit::MAX_PROCESS_SIZE = 470_000;
>>   $Apache2::SizeLimit::MIN_SHARE_SIZE = 50_000;
>
> See the section in Apache2/SizeLimit.pm
> =head1 DEPRECATED APIS
>
> <quote>
> Direct use of these globals is deprecated, but will continue to work
> for the foreseeable future.
> </quote>
>
>
> But it should be trivial to write this instead:
>  Apache2::SizeLimit->set_check_interval(30);


Philip I think you have 3 official +1s, a green light for release.




>
>  Apache2::SizeLimit->set_max_process_size(470_000);   # Max size in KB
>  Apache2::SizeLimit->set_min_shared_size(50_000);     # Min share in KB
>
> - --
> - ------------------------------------------------------------------------
> 1024D/DB9B8C1C B90B FBC3 A3A1 C71A 8E70  3F8C 75B8 8FFB DB9B 8C1C
> Philip M. Gollucci ([email protected]) c: 703.336.9354
> VP Apache Infrastructure; Member, Apache Software Foundation
> Committer,                        FreeBSD Foundation
> Consultant,                       P6M7G8 Inc.
> Sr. System Admin,                 Ridecharge Inc.
>
> Work like you don't need the money,
> love like you'll never get hurt,
> and dance like nobody's watching.
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v2.0.14 (FreeBSD)
>
> iD8DBQFMXFGJdbiP+9ubjBwRArl2AKCN2QxfXfWOkzf9hEA7L+XjhHr7qwCfcsA2
> LA0l9nLBEgJKlJErlJMuaKE=
> =4yd2
> -----END PGP SIGNATURE-----
>