Bugs + fixes for build/make_rpm_spec

Thomas Busch <[email protected]>
Newsgroups gmane.comp.apache.mod-perl
Message-ID <[email protected]>
Hi,

build/make_rpm_spec doesn't build a valid mod_perl.spec file
(%define _release doesn't get set properly) if .svn/entries doesn't
contain a line with "revision=".

What I propose is to replace

my $release   = $dev_build ? svn_release() : 1;

by

my $release   = $dev_build ? svn_release() || 0 : 1;

Furthermore on CentOS 5.7/32 bit even with this modification
the resulting RPM files won't install properly.

If the following gets added after the last BuildRequires:
it should work.

%define __perl_requires /usr/lib/rpm/perl.req $* |\
                         sed -e '/perl(Apache2::FunctionTable)/d' \
                             -e '/perl(Apache2::StructureTable)/d' \
                             -e '/perl(Apache::Test.*)/d' \
                             -e '/perl(TAP::.*)/d' \
                             -e '/perl(Data::Flow)/d' \
                             -e '/perl(Module::Build)/d'

%define __perl_provides /usr/lib/rpm/perl.prov $* | \
                         sed -e '/perl(warnings)/d'  \
                             -e '/HTTP::Request::Common)/d'

Could someone review this and check this in ?

Thanks in advance.

Thomas.
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.