[jira] Commented: (SANDESHA2-185) Sandesha2 need to support JTA transactions

    [ https://issues.apache.org/jira/browse/SANDESHA2-185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12655975#action_12655975 ] 

Andrew Gatford commented on SANDESHA2-185:
------------------------------------------

I had a couple of comments on the patch:
1) You are still inserting spaces instead of tabs - please update your editor
2) The InvokerWorker has had a number of imports added which aren't used.
3) I'm not sure about the point of the getTransaction change inside the InvokerWorker.  In the storagemanager implementations that I've seen - if there is a transaction in use then calling getTransaction would always return a null.  This then protects sending responses from inside an invoke, so if there is an error, the transaction is rolled back and the service can be re-invoked.
Have you got any unit tests that demonstrate this functionality works ?

> Sandesha2 need to support JTA transactions
> ------------------------------------------
>
>                 Key: SANDESHA2-185
>                 URL: https://issues.apache.org/jira/browse/SANDESHA2-185
>             Project: Sandesha2
>          Issue Type: New Feature
>            Reporter: irantha suwandarathna
>         Attachments: Sandesha2_JTA.patch
>
>
> Sandesha2 need to be able to participate in JTA transactions.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.