Re: Portability: common-src/ammessage.c

Jean-Louis Martineau writes:
- Eric,
- 
- I committed the attached patch

Thank you, I'll include the patch in pkgsrc, until the next
version of Amanda is released.

Many thanks,
	Eric

- On 03/01/17 11:24 AM, Eric Schnoebelen wrote:
- > Jean-Louis Martineau writes:
- > - We don't care if they are defined by gnulib or not, what is
- > - important is the array size, the check should be like:
- > -
- > - #if defined(EBADMSG) && EBADMSG<500
- > -
- > - A constant should be use instead of harcoding 500, we could
- > - increase it to 2500
- > -
- > - #define MAX_ERRCODE 500
- > - char *errcode[MAX_ERRCODE];
- > -
- > - #if defined(EBADMSG) && EBADMSG<MAX_ERRCODE
- > -
- > - All use of errode[] must also be checked for the value <MAX_ERRCODE
- >
- > All of the above are reasonable.
- >
- > I was attemping a minimally invasive patch for packaging as part
- > of pkgsrc (the cross platform packaging system from NetBSD.)