amcheck -m sends single blank line to stdout on success
Jason L Tibbitts III <[email protected]>
| Newsgroups | gmane.comp.archivers.amanda.devel |
|---|---|
| Message-ID | <[email protected]> |
So for approximately forever I've run "amcheck -m" a few times a day
from cron. After an update from 3.3.9 to 3.4.1, though, I found that
every run causes cron to send an email because amcheck -m will always
output a single line to stdout. I believe this comes from a single
unconditional printf("\n"); in amcheck.c:main():
diff --git a/server-src/amcheck.c b/server-src/amcheck.c
index a62589f..143c839 100644
--- a/server-src/amcheck.c
+++ b/server-src/amcheck.c
@@ -714,7 +714,6 @@ main(
}
}
- printf("\n");
g_debug("server_probs: %d", server_probs);
g_debug("client_probs: %d", client_probs);
dbclose();
I know I could just fix the cron job to redirect to null but the
unconditional output doesn't really seem particularly useful while the
old "cron will email me even if amcheck fails to send a message"
behavior still seems reasonable.
- J<