Re: amvault hanging

This patch should fix it.

The behavior of size==0 changed, from everything to nothing, the API now 
use a size of -1 of everything.
I appreciate if you can try the patch and confirm it works.

Jean-Louis

On 19/05/17 02:32 PM, Orion Poplawski wrote:
> On 05/19/2017 12:21 PM, Jean-Louis Martineau wrote:
> > On 19/05/17 01:43 PM, Orion Poplawski wrote:
> >> This was dumped by 3.3.3. I use some custom code to "flush" the 
> backups from
> >> holdingdisk to final directory so that might be a source of errors 
> as well,
> >> but this amdump log was written by amanda proper. I've attached the 
> amflush
> >> log written by my script as well.
> > That's the problem, your script write the size in kb, while amanda 
> write it in
> > bytes since 3.3.0
> > You have:
> > PART taper Offsite-01 5 alxdisk1ib /export/clouds 20170513031353 
> 1/-1 0 [sec
> > 0.000278 kb 6140921786 kps 22089959529273.523438 orig-kb 6140921786]
> > DONE taper alxdisk1ib /export/clouds 20170513031353 1 0 [sec 0.000278 kb
> > 6140921786 kps 22089959529273.523438 orig-kb 6140921786]
> > It should be:
> > PART taper Offsite-01 5 alxdisk1ib /export/clouds 20170513031353 
> 1/-1 0 [sec
> > 0.000278 bytes 6288303908864 kps 22089959529273.523438 orig-kb 
> 6140921786]
> > DONE taper alxdisk1ib /export/clouds 20170513031353 1 0 [sec 
> 0.000278 bytes
> > 6288303908864 kps 22089959529273.523438 orig-kb 6140921786]
> >
> > Can you do the change and retry a new amvault?
>
> That did the trick, thanks! Unfortunate that it can't handle pre 3.3, 
> but I
> suppose that's pretty old at this point.
>
>
> -- 
> Orion Poplawski
> Technical Manager 720-772-5637
> NWRA, Boulder/CoRA Office FAX: 303-415-9702
> 3380 Mitchell Lane [email protected]
> Boulder, CO 80301 http://www.nwra.com 
> <http://www.nwra.com>
This message is the property of CARBONITE, INC. and may contain confidential or privileged information.
If this message has been delivered to you by mistake, then do not copy or deliver this message to anyone.  Instead, destroy it and notify me by reply e-mail

diff --git a/perl/Amanda/Vault.pm b/perl/Amanda/Vault.pm
index dd6be4f..114e75c 100644
--- a/perl/Amanda/Vault.pm
+++ b/perl/Amanda/Vault.pm
@@ -747,6 +747,7 @@ sub xfer_dumps {
 	$xfer = Amanda::Xfer->new([ $xfer_src, $xfer_dst ]);
 	my $size = 0;
 	$size = $current->{'dump'}->{'bytes'} if exists $current->{'dump'}->{'bytes'};
+	$size = -1 if $size == 0;
 	$xfer->start($steps->{'handle_xmsg'}, 0, $size);
 
 	# count the "threads" running here (clerk and scribe)