Re: amdump --no-taper does not put driver into degraded mode with 3.4.4

Orion,

Thanks for a better description of the problem.

Try the attached patch.

Jean-Louis


On 14/06/17 06:57 PM, Orion Poplawski wrote:
> On 06/14/2017 11:58 AM, Jean-Louis Martineau wrote:
> > On 14/06/17 01:24 PM, Orion Poplawski wrote:
> >> Not sure what is helpful. Here is amdump file and some debug logs.
> >
> > Show me where you get [can't dump in non degraded mode]
>
> I'm not getting it at the moment because all of the dumps are fitting 
> in the
> holding disk. I'll see if the issue re-appears.
>
> > Tell me what is the real problem, is it only because you do no see 
> 'dump of
> > driver schedule before start degraded mode'.
> > Tell me the behavior you do not like, tell me what you get and what 
> you expect.
>
> The problem is that with --no-taper it appears that we're no longer 
> entering
> degraded mode at the start to the amdump/driver process so level 0 
> dumps that
> don't fit are not being dropped back to incrementals that do.
>
> Previously (with 3.3.9) the driver would immediately go into degraded 
> mode as
> evidenced by the "dump of driver schedule" before and after messages. I no
> longer see these in the amdump log so it appears that 
> start_degraded_mode() is
> not being called.
>
> perhaps your patch will fix the issue and I'm just not exercising it yet
> because I'm not filling up the holding disk.
>
> >
> > Jean-Louis
> >>
> >> On 06/14/2017 11:09 AM, Jean-Louis Martineau wrote:
> >> > Orion,
> >> >
> >> > Then post more information, I do not see how you can get [can't 
> dump in non
> >> > degraded mode] with the patch and with --no-taper
> >> >
> >> > Jean-Louis
> >> >
> >> > On 14/06/17 10:36 AM, Orion Poplawski wrote:
> >> >> That did not appear to help. Tested with 3.4.5 + patch.
> >> >>
> >> >> On 06/13/2017 08:11 AM, Jean-Louis Martineau wrote:
> >> >> > Orion,
> >> >> >
> >> >> > Can you try the attached patch?
> >> >> >
> >> >> > Jean-Louis
> >> >> >
> >> >> > On 12/06/17 05:01 PM, Orion Poplawski wrote:
> >> >> >> I recently updated from 3.3.9 to 3.4.4 and now it appears 
> that "amdump
> >> >> >> --no-taper" does not put driver into degraded mode. Any 
> suggestions of
> >> what
> >> >> >> to check? Basically I no longer see the:
> >> >> >>
> >> >> >> dump of driver schedule before start degraded mode:
> >> >> >>
> >> >> >> and
> >> >> >>
> >> >> >> dump of driver schedule after start degraded mode:
> >> >> >>
> >> >> >> messages in the amdump log and I now see dump errors like:
> >> >> >>
> >> >> >> earthib /export/backup lev 0 FAILED [can't dump in non 
> degraded mode]
> >> >> >>
> >> >> >> Thanks.
> >> >> >>
> >> >> >> --
> >> >> >> Orion Poplawski
> >> >> >> Technical Manager 720-772-5637
> >> >> >> NWRA, Boulder/CoRA Office FAX: 303-415-9702
> >> >> >> 3380 Mitchell Lane [email protected]
> >> >> >> Boulder, CO 80301 http://www.nwra.com 
> <http://www.nwra.com>
> >> >> >
> >> >> >
> >> >> >
> >> >> >
> >> >> > *Disclaimer*
> >> >> >
> >> >> > This message is the property of *CARBONITE, INC.*
> >> <http://www.carbonite.com 
> <http://www.carbonite.com>>
> >> >> > and may contain confidential or privileged information.
> >> >> >
> >> >> > If this message has been delivered to you by mistake, then do 
> not copy or
> >> >> > deliver this message to anyone. Instead, destroy it and notify 
> me by reply
> >> >> e-mail.
> >> >> >
> >> >>
> >> >>
> >> >> --
> >> >> Orion Poplawski
> >> >> Technical Manager 720-772-5637
> >> >> NWRA, Boulder/CoRA Office FAX: 303-415-9702
> >> >> 3380 Mitchell Lane [email protected]
> >> >> Boulder, CO 80301 http://www.nwra.com 
> <http://www.nwra.com>
> >> >
> >> >
> >> >
> >> >
> >> > *Disclaimer*
> >> >
> >> > This message is the property of *CARBONITE, INC.* 
> <http://www.carbonite.com 
> <http://www.carbonite.com>>
> >> > and may contain confidential or privileged information.
> >> >
> >> > If this message has been delivered to you by mistake, then do not 
> copy or
> >> > deliver this message to anyone. Instead, destroy it and notify me 
> by reply
> >> e-mail.
> >> >
> >>
> >>
> >> --
> >> Orion Poplawski
> >> Technical Manager 720-772-5637
> >> NWRA, Boulder/CoRA Office FAX: 303-415-9702
> >> 3380 Mitchell Lane [email protected]
> >> Boulder, CO 80301 http://www.nwra.com 
> <http://www.nwra.com>
> >
> >
> >
> >
> > *Disclaimer*
> >
> > This message is the property of *CARBONITE, INC.* 
> <http://www.carbonite.com 
> <http://www.carbonite.com>>
> > and may contain confidential or privileged information.
> >
> > If this message has been delivered to you by mistake, then do not 
> copy or
> > deliver this message to anyone. Instead, destroy it and notify me by 
> reply e-mail.
> >
>
>
> -- 
> Orion Poplawski
> Technical Manager 720-772-5637
> NWRA, Boulder/CoRA Office FAX: 303-415-9702
> 3380 Mitchell Lane [email protected]
> Boulder, CO 80301 http://www.nwra.com 
> <http://www.nwra.com>
This message is the property of CARBONITE, INC. and may contain confidential or privileged information.
If this message has been delivered to you by mistake, then do not copy or deliver this message to anyone.  Instead, destroy it and notify me by reply e-mail

diff --git a/server-src/driver.c b/server-src/driver.c
index ec02183..808cc14 100644
--- a/server-src/driver.c
+++ b/server-src/driver.c
@@ -2009,7 +2009,7 @@ start_degraded_mode(
     }
 
     if (!schedule_degraded) {
-	gboolean one_degraded_mode = FALSE;
+	gboolean one_degraded_mode = (nb_storage == 0);
 	schedule_degraded = TRUE;
 
 	for (taper = tapetable; taper < tapetable+nb_storage ; taper++) {
@@ -2033,7 +2033,7 @@ start_degraded_mode(
 	    /* go ahead and do the disk as-is */
 	    enqueue_sched(&newq, sp);
 	} else {
-	    gboolean must_degrade_dp = FALSE;
+	    gboolean must_degrade_dp = (nb_storage == 0);
 	    for (taper = tapetable; taper < tapetable+nb_storage ; taper++) {
 		if (taper->degraded_mode &&
 		    dump_match_selection(taper->storage_name, sp)) {
@@ -2067,7 +2067,7 @@ start_degraded_mode(
     }
 
     /*@i@*/ *queuep = newq;
-    all_degraded_mode = TRUE;
+    all_degraded_mode = (nb_storage == 0);
     for (taper = tapetable; taper < tapetable+nb_storage ; taper++) {
 	all_degraded_mode &= taper->degraded_mode;
     }