Re: Streamlined application/script development [Re: coding an Application in perl]

Chapman Flack <[email protected]> Fri, 1 Sep 2017 10:01:31 -0400
Newsgroups gmane.comp.archivers.amanda.devel
Message-ID <[email protected]>
On 09/01/2017 09:41 AM, Jean-Louis Martineau wrote:

> 'directory' is not a good name, so if you get a better name, we can use it.

Hmm, destination? workspace? ...? Does that mean you would consider
changing it for all apps old and new in order to have it consistent?

I was trying to avoid any change to existing behavior (but it's true,
I didn't feel right using 'directory' for things that weren't
directories).

> The Abstract class should not check if 'directory' is a directory.

I think it should chdir() there, if it is a directory, since that would
otherwise be duplicated code in all applications. So I guess it should
still check, but if it is not an actual directory, should simply accept
it quietly? Then the application subclass will just have to check the
option and know what to do with it anyway.

> I'm not sure that all the declare_*_options are required as everything
> 'backup' need must be accepted for all commands.

OK, I wasn't sure about that. There might still be extra 'restore'
properties, right? Because you can set those in an amrecover session.

-Chap