Re: some fixes to Vault.pm (Amanda 3.4)

Nathan Stratton Treadway <[email protected]> Fri, 22 Sep 2017 23:44:02 -0400
Newsgroups gmane.comp.archivers.amanda.devel
Message-ID <[email protected]>
On Fri, Sep 22, 2017 at 22:03:54 -0400, Nathan Stratton Treadway wrote:
> On Fri, Sep 22, 2017 at 09:04:05 -0400, Jean-Louis Martineau wrote:
> > Nathan,
> > 
> > Thanks for both patch.
> > I committed the attached patch, I made some more fix, can you try them?
> > 
> 
> I didn't rebuild everything from scratch, but I believe I applied the
> patches correctly to amvault and Vault.pm, and now when I run something
> like
>   su backup -c "amvault TestBackup --dest-storage TestOffsite --dry-run --src-labelstr TESTBACKUP \* 2>&1"
> or 
>   su backup -c "amvault TestBackup --dest-storage TestOffsite --dry-run --src-timestamp latest 2>&1"
> 
> , the last line of the output is:
> 
> amvault: Can't call method "quit" on an undefined value at /usr/lib/x86_64-linux-gnu/amanda/perl/Amanda/Vault.pm line 899.
> 

When I run "amvault" without "--dry-run":
  1) the "Can't call method "quit"...." error does _not_ appear, and

  2) the progress messages now update-in-place on one line on the
     terminal (and they do say "NNNNNN kbytes written").


							Nathan

----------------------------------------------------------------------------
Nathan Stratton Treadway  -  [email protected]  -  Mid-Atlantic region
Ray Ontko & Co.  -  Software consulting services  -   http://www.ontko.com/
 GPG Key: http://www.ontko.com/~nathanst/gpg_key.txt   ID: 1023D/ECFB6239
 Key fingerprint = 6AD8 485E 20B9 5C71 231C  0C32 15F3 ADCD ECFB 6239