lexical.pm last_use_label ignores "storage" field on tapelist

Testing with Amanda 3.5.1 (from the Debian 1:3.5.1-1 packages):

I have two storages defined in my test environment, "TestBackup" with
tables labeled TESTBACKUP-01 through TESTBACKUP-21 and "TestOffsite" with
tapes labeled TESTBACKUP-101 through TESTBACKUP-109.

I'm using the lexical taper scan algorithm (for both storages), and the
TestBackup storage is a vtape array constantly left mounted (so all 21
vtapes are always available).

I noticed that when left to its own devices (for the "TestBackup"
storage), Amanda seemed to jump right to tape TESTBACKUP-11 as soon as
it was available for use (i.e. once it rolled out of the Tapecycle
count).

In attempting to track this down within at lexical.pm, I see  that that
the last_use_label() function ignores the storage parameter when
searching the tapelist -- which means that in my case $last_label is
always set to "TESTBACKUP-10x", and thus when the TestBackup tables are
sorted lexically compared to that, TESTBACKUP-11 always comes up "next".

(I have TestOffsite listed as my vault-storage, so the offsite tape is
always written after the "onsite" vape, and thus appears as element 0 of
the tapelist.)


Jean-Louis, am I correct that last_use_label() does need to limit itself
to looking at tapes within the "current" storage?

							Nathan

----------------------------------------------------------------------------
Nathan Stratton Treadway  -  [email protected]  -  Mid-Atlantic region
Ray Ontko & Co.  -  Software consulting services  -   http://www.ontko.com/
 GPG Key: http://www.ontko.com/~nathanst/gpg_key.txt   ID: 1023D/ECFB6239
 Key fingerprint = 6AD8 485E 20B9 5C71 231C  0C32 15F3 ADCD ECFB 6239