Re: Buffer overflow in name_to_tcb

Lasse Kliemann <[email protected]> Wed, 6 Jul 2011 11:56:50 +0200
Newsgroups gmane.comp.archivers.star.user
Message-ID <[email protected]>
--===============1015080813419576390==
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="ftEhullJWpWg/VHq"
Content-Disposition: inline


--ftEhullJWpWg/VHq
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

* Message by -Joerg Schilling- from Wed 2011-06-15:

> > > There is a trick to make over-picky compilers quiet......
> > >=20
> > > change strcpy(ptb->dbuf.t_name, name); to:
> > >=20
> > > 	strcpy(ptb->ndbuf.t_name, name);
> > >=20
> > > and try again.....
> >
> > This works.
> >
> > Is it intended as a permanent fix?
>=20
> This is seen as a workaround as an intentionally wrong data structure var=
iant=20
> cannot be seen as a fix.

I see the workaround has been incorporated into 2011-06-22.

I have compiled that version with my usual CFLAGS including

  -fstack-protector-all -D_FORTIFY_SOURCE=3D2

There were no more problems, although I pushed a dozen TB through=20
star the last days.

--ftEhullJWpWg/VHq
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iQIcBAEBAgAGBQJOFDFiAAoJEFYll6N4nhdvErYQAI1ReSQhVPZbcmzPkL20ZovC
i75CpT84vjiDT/IUuifukiNnFD64MueMeUR3f0RjDKbr9McI6t9CNAb8Njr6INL7
EEUocQoBsuxNkYvhNSypmgeMwonYO3a1UAx14ICdr53gxw8FVs9ObU/8ey/Qd4Nm
GJOe7VKh77acv/KnvL58OGqJ/gw+5AHt8nvWFT1bhm7fwIGQn1XsXl0SH0Itrf5h
D2KJRcWgbsSbuHL//i80rvbAF23L7/M1vKIyg2e4QzwzCjR8k/BCTo9AFXwLpcRD
E4UUoEOL3xbvcCnVOlvDr+a/bLXfAGze1ERcsvMhk97YuJjCTBhfYnigjy0tTBOH
dx9JWLRqS2xVx5NaLUdg7uc6rMLHG/Bn9CYQ08u7vGrgU1DgWJ80cdK86EaNFEt2
x43GuuHm58eMJ1wdPt/sm8XE2iA4rMfgRP2tlxSeFTMsO1lNcZwrIlkSSrYLtyp4
nUBZZ6e+QpMnqtFyOOuBwbPyKGCMDb8qfyXzSUbHdI9MsuRcKgQQJfl4kZGQJ/Pd
4BrPgbklJA4BaTfqtALs96C0xMuD6XcblyHkPhIpyIjLRDOrW1tBVXnO8DCq+Vzw
uC6YbMKW84gMM8OaaTlQv3frSPaQDKZdkjWKFJgL+3IP17HCKayMOsrDXjg94TGv
DgxWCnj7WAQpTBRII4Vh
=B2WP
-----END PGP SIGNATURE-----

--ftEhullJWpWg/VHq--

--===============1015080813419576390==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Star-users mailing list
[email protected]
https://lists.berlios.de/mailman/listinfo/star-users

--===============1015080813419576390==--