s/Phase/Polarity

On 06/09/2016 09:08 PM, [email protected] wrote:
>
> - Log -----------------------------------------------------------------
> commit 37aed5715b69428f86b169377f9597e563fff7df
> Author: Len Ovens <[email protected]>
> Date:   Thu Jun 9 12:07:57 2016 -0700
>
>     OSC: add phase control
>
<..>
> +#include "ardour/phase_control.h"
>
>  #include "osc_select_observer.h"
>  #include "osc.h"
> @@ -526,6 +527,8 @@ OSC::register_callbacks()
>  		REGISTER_CALLBACK (serv, "/select/pan_stereo_position", "f", sel_pan_position);
>  		REGISTER_CALLBACK (serv, "/select/pan_stereo_width", "f", sel_pan_width);
>
> +		REGISTER_CALLBACK (serv, "/select/phase", "i", sel_phase);
> +

Can I suggest to change the name of this control to "polarity" rather 
than phase, at least in all user-visible places? The audio engineering 
teachers of this world will love you for ever after, and our dear late 
Eberhard Sengpiel will stop spinning in his grave at audio frequencies.

:-D

-- 
Jörn Nettingsmeier
Lortzingstr. 11, 45128 Essen, Tel. +49 177 7937487

Meister für Veranstaltungstechnik (Bühne/Studio)
Tonmeister VDT

http://stackingdwarves.net