Windows 32-bit release build broken when using VS 2019

This has started happening within the last few days and, near as I can tell,
is due to an update of VS2019.  The last github action build to work was 8
days ago for bug 2688.  It was built using 16.8.3 of VS2019.  The last
github action build (for a pull request) failed and it was using 16.9.0 of
VS2019.  

 

Sample error messages:

 

2021-03-16T06:34:31.4733984Z
D:\a\audacity\audacity\src\float_cast.h(61,2): error C2169: 'lrint':
intrinsic function, cannot be defined (compiling source file
D:\a\audacity\audacity\src\AudioIO.cpp)
[D:\a\audacity\audacity\build\src\Audacity.vcxproj]

2021-03-16T06:34:31.4735494Z
D:\a\audacity\audacity\src\float_cast.h(73,2): error C2169: 'lrintf':
intrinsic function, cannot be defined (compiling source file
D:\a\audacity\audacity\src\AudioIO.cpp)
[D:\a\audacity\audacity\build\src\Audacity.vcxproj]

 

So the knee-jerk reaction is to simply stop using our versions of the
various "rint()" functions.  I tried that a while back and our performance
tanked. So, I just it a try again:

 

With 16.9.2 and our "rint" functions removed, exporting a 2 hour projects to
WAV takes 2 minutes 34!  Using the last github build that worked (VS 16.8.3)
which is using our versions of the "rint" functions takes a mere 17 seconds.

 

I'm still looking for a better solution than just trashing our "rint"
functions and whether the VS 16.8 vs is VS 16.9 is causing the problem.

 

I bring this up because you know folks are going to start building with 16.9
since it's the latest downloadable from Microsort.

_______________________________________________
audacity-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/audacity-devel