Re: How to locate a commit?

John Colket <[email protected]> Tue, 13 Apr 2021 13:51:51 -0400
Newsgroups gmane.comp.audio.audacity.devel
Message-ID <CAHCiZT-ugOcNa1K4QKK19-z2rEy+nC4=tvdJPcGq3sUy5ERY+g@mail.gmail.com>
[Back on topic]

Poke,

  Thanks again for your post.  I was able to locate the commit in question
without too much difficulty.  I did not know that a clone contained that
much rich commit history. ☺

  Anyway, for those that are following the post, the commit of interest was
the fix for "Bug 2617 - Audacity not responding after switching to Envelope
tool", which makes perfect sense to me - I had noticed a lot more painting
and refreshing going on than I would have ever thought.  And I had been
looking at this code trying to understand it - but I did skip over the part
commented by the bug, and I'll have a closer look to see what is going on.

  Regardless, again, thanks for your help. ☺

- John

On Mon, Apr 12, 2021 at 3:02 PM Pokechu22 <
[email protected]> wrote:

> The fastest way to locate a commit is to use git bisect, as it requires
> you to check a logarithmic number of commits (so for 1000 commits, you only
> need to check 10 or so of them).  It can be a bit complicated to get
> started with, but https://git-scm.com/docs/git-bisect-lk2009 is a pretty
> helpful guide.
>
> --Poke
>
> On Mon, Apr 12, 2021 at 11:55 AM John Colket <[email protected]> wrote:
>
>> James,
>>
>> I would like to say that I'm glad you asked that question ☺ - but
>> actually I'm not. 😉
>>
>> Well anyway, since you asked, some users have ended up unknowingly
>> screwing up their project by accidentally bumping the track and/or pan
>> controls whilst editing their projects.  So I have been looking into this.
>>
>> Peter has written up a proposal to address this issue.  I am sure you are
>> aware of it.  See here:
>> https://wiki.audacityteam.org/wiki/Proposal_Locking_and/or_Hiding_Pan_and_Gain_sliders
>>
>> Personally, I believe most of the suggestions are overkill, with the
>> exceptions of the Visual Cues; I have written up my own thoughts on the
>> adjoining Discussion page for that proposal.
>>
>> But here is what I was trying to look into.  There was a very, very
>> subtle change between 2.4.2, and 3.0.0, that perhaps has gone unnoticed.
>> That is when the cursor is drawn off of the Pan slider in a downward
>> direction, that the highlight on its control remains. This in my view is a
>> regression on 2.4.2, makes the visual cues just a little bit poorer, and
>> makes the whole issue just a teensy bit harder to tackle.
>>
>> - John
>>
>> On Mon, Apr 12, 2021 at 12:40 PM James Crook <[email protected]>
>> wrote:
>>
>>> If the artifacts are expired, you only have FossHub old audacity,
>>> https://www.fosshub.com/Audacity-devel-old.html for prebuilts.  So
>>> you're back to building them yourself - if they were not changes around
>>> release candidate time.
>>>
>>> Which behaviour change are you hoping to track down?
>>>
>>> --James.
>>>
>>> On Mon, 12 Apr 2021 at 17:05, John Colket <[email protected]> wrote:
>>>
>>>> James,
>>>>
>>>> I would like to search for an unknown commit that changed a certain
>>>> behavior between 2.4.2 and 3.0.0.  So the Artifacts are by now
>>>> well-expired.  Is there any way to travel in the "way back machine" so I
>>>> can do a binary search ?
>>>>
>>>> - John
>>>>
>>> _______________________________________________
>> audacity-devel mailing list
>> [email protected]
>> https://lists.sourceforge.net/lists/listinfo/audacity-devel
>>
> _______________________________________________
> audacity-devel mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/audacity-devel
>

_______________________________________________
audacity-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/audacity-devel