Re: Compilation fails on 3.0.0 if ffmpeg disabled

On Wed, Apr 14, 2021 at 1:29 PM Jack L. <[email protected]> wrote:

> 2742 is fixed with the latest Leland fix.
>

Thanks for that report - I've closed the bug on the basis of your testing.

Many thanks for that - much appreciated   😎

Peter.



> On Tue, Apr 13, 2021 at 2:50 AM James Crook <[email protected]>
> wrote:
> >
> > 2742 combines two reports from Jack, and I think, yes is QUICKFIXED, but
> please wait for Jack to confirm so.  The miracle of it compileth may not be
> the full story of 2742.
> >
> > --James.
> >
> > On Tue, 13 Apr 2021 at 10:21, Peter Sampson <
> [email protected]> wrote:
> >>
> >>
> >>
> >> On Tue, Apr 13, 2021 at 6:27 AM Jack L. <[email protected]> wrote:
> >>>
> >>> It compileths with ffmpeg on or off, miracle!
> >>
> >>
> >> @James:
> >>
> >> Does that mean that this bug is RESOLVED QUICKFIXED ?
> >> Bug 2742 - FreeBSD Compilation issues
> >>
> >> Peter.
> >>
> >>
> >>>
> >>> On Mon, Apr 12, 2021 at 9:04 PM Leland <[email protected]> wrote:
> >>> >
> >>> > Okay Jack, pull down the updates and trying building again.
> >>> >
> >>> > > -----Original Message-----
> >>> > > From: Jack L. <[email protected]>
> >>> > > Sent: Monday, April 12, 2021 8:46 PM
> >>> > > To: Audacity-Devel list <[email protected]>
> >>> > > Subject: Re: [Audacity-devel] Compilation fails on 3.0.0 if ffmpeg
> >>> > disabled
> >>> > >
> >>> > > Was trying to make a patch when I realized that the problem is not
> as
> >>> > simple
> >>> > > as originally thought. In the case if we disable ffmpeg
> >>> > >
> >>> > > src/FFmpeg.h only #include <errno.h> if we are #if
> defined(USE_FFMPEG) but
> >>> > > we should be #include <errno.h> regardless for
> src/widgets/FileConfig.cpp
> >>> > >
> >>> > > In src/import/Import.cpp, we are calling ffmpeg functions but they
> aren't
> >>> > > available since everything in FFmpeg.h is wrapped around an #if
> >>> > > defined(USE_FFMPEG)
> >>> > >
> >>> > > Thoughts?
> >>> > >
> >>> > > On Mon, Apr 12, 2021 at 3:53 PM James Crook <
> [email protected]>
> >>> > > wrote:
> >>> > > >
> >>> > > > Then put git and github on your learning list for a future date,
> and
> >>> > just
> >>> > > propose patches instead.
> >>> > > > We have some traditional people here who still understand
> patches :-)
> >>> > > >
> >>> > > > --James.
> >>> > > >
> >>> > > > On Mon, 12 Apr 2021 at 20:18, Jack L. <[email protected]>
> wrote:
> >>> > > >>
> >>> > > >> How do i do that? New to git
> >>> > > >>
> >>> > > >> On Mon, Apr 12, 2021 at 7:58 AM James Crook
> >>> > > <[email protected]> wrote:
> >>> > > >> >
> >>> > > >> > So - We WILL be doing an RC02 for other reasons.
> >>> > > >> >
> >>> > > >> > Jack could you make a pull request for the two compilation
> issues for
> >>> > > FreeBSD, and that way we can get them into RC02?
> >>> > > >> >
> >>> > > >> > --James.
> >>> > > >> >
> >>> > > >> > On Mon, 12 Apr 2021 at 11:33, James Crook <
> [email protected]>
> >>> > > wrote:
> >>> > > >> >>
> >>> > > >> >> Thanks.
> >>> > > >> >>
> >>> > > >> >> I've added a bugzilla entry
> >>> > > https://bugzilla.audacityteam.org/show_bug.cgi?id=2742, P2, and
> we can fix
> >>> > > these as soon as we lift code freeze for 3.0.2 (or if we have to do
> >>> > another RC
> >>> > > for other reasons).
> >>> > > >> >>
> >>> > > >> >> --James.
> >>> > > >> >>
> >>> > > >> >>
> >>> > > >> >>
> >>> > > >> >> On Mon, 12 Apr 2021 at 05:49, Jack L. <[email protected]>
> wrote:
> >>> > > >> >>>
> >>> > > >> >>> Looks like if compiling with
> >>> > > >> >>>
> >>> > > >> >>>  -Daudacity_use_ffmpeg:STRING=off
> >>> > > >> >>>
> >>> > > >> >>> results in a compilation failure.
> >>> > > >> >>>
> >>> > > >> >>>
> >>> > > >> >>> [1/142] cd
> >>> > > >> >>>
> /backup/obj/usr/ports/audio/audacity3/work/audacity-minsrc-3.0.0
> >>> > > >> >>> && /usr/local/bin/cmake -D GIT=/usr/local/bin/git -D
> >>> > > >> >>>
> _PRVDIR=/backup/obj/usr/ports/audio/audacity3/work/.build/src/pri
> >>> > > >> >>> vate -P
> >>> > > >> >>>
> /backup/obj/usr/ports/audio/audacity3/work/audacity-minsrc-3.0.0/
> >>> > > >> >>> cmake-proxies/cmake-modules/Version.cmake
> >>> > > >> >>> [2/142] /usr/bin/c++ -DAudacity_EXPORTS -DBUILDING_AUDACITY
> >>> > > >> >>> -DCMAKE -DHAVE_LRINT -DHAVE_LRINTF -DHAVE_MLOCK
> >>> > > >> >>> -DWXINTL_NO_GETTEXT_MACRO -DWXUSINGDLL -
> >>> > > D_FILE_OFFSET_BITS=64
> >>> > > >> >>> -D_THREAD_SAFE -D__WXGTK__ -Isrc/private
> >>> > > >> >>>
> -I/backup/obj/usr/ports/audio/audacity3/work/audacity-minsrc-3.0.
> >>> > > >> >>> 0/include
> >>> > > >> >>>
> -I/backup/obj/usr/ports/audio/audacity3/work/audacity-minsrc-3.0.
> >>> > > >> >>> 0/src
> >>> > > >> >>> -I/usr/local/lib/wx/include/gtk3-unicode-3.1
> >>> > > >> >>> -I/usr/local/include/wx-3.1
> >>> > > >> >>>
> -I/backup/obj/usr/ports/audio/audacity3/work/audacity-minsrc-3.0.
> >>> > > >> >>> 0/lib-src/lame
> >>> > > >> >>>
> -I/backup/obj/usr/ports/audio/audacity3/work/audacity-minsrc-3.0.
> >>> > > >> >>> 0/lib-src/portsmf/include
> >>> > > >> >>>
> -I/backup/obj/usr/ports/audio/audacity3/work/audacity-minsrc-3.0.
> >>> > > >> >>> 0/lib-src/libnyquist
> >>> > > >> >>>
> -I/backup/obj/usr/ports/audio/audacity3/work/audacity-minsrc-3.0.
> >>> > > >> >>> 0/lib-src/portmixer/include
> >>> > > >> >>>
> -I/backup/obj/usr/ports/audio/audacity3/work/audacity-minsrc-3.0.
> >>> > > >> >>> 0/lib-src/libsbsms/include -isystem /usr/local/include
> -isystem
> >>> > > >> >>> /usr/local/include/opus -isystem
> /usr/local/include/soundtouch
> >>> > > >> >>> -isystem /usr/local/include/glib-2.0 -isystem
> >>> > > >> >>> /usr/local/lib/glib-2.0/include -isystem
> >>> > > >> >>> /usr/local/include/gtk-3.0 -isystem
> /usr/local/include/pango-1.0
> >>> > > >> >>> -isystem /usr/local/include/fribidi -isystem
> >>> > > >> >>> /usr/local/include/cairo -isystem
> /usr/local/include/pixman-1
> >>> > > >> >>> -isystem
> >>> > > >> >>> /usr/local/include/freetype2 -isystem
> /usr/local/include/libdrm
> >>> > > >> >>> -isystem /usr/local/include/libpng16 -isystem
> >>> > > >> >>> /usr/local/include/harfbuzz -isystem
> >>> > > >> >>> /usr/local/include/gdk-pixbuf-2.0 -isystem
> >>> > > >> >>> /usr/local/include/gio-unix-2.0 -isystem
> >>> > > >> >>> /usr/local/include/libepoll-shim -isystem
> >>> > > >> >>> /usr/local/include/atk-1.0 -isystem
> >>> > > >> >>> /usr/local/include/at-spi2-atk/2.0 -isystem
> >>> > > >> >>> /usr/local/include/dbus-1.0 -isystem
> >>> > > >> >>> /usr/local/lib/dbus-1.0/include -isystem
> >>> > > >> >>> /usr/local/include/at-spi-2.0 -O2 -pipe -march=westmere
> >>> > > >> >>> -fstack-protector-strong -fno-strict-aliasing -O2 -pipe
> >>> > > >> >>> -march=westmere -fstack-protector-strong
> -fno-strict-aliasing
> >>> > > >> >>> -Wno-underaligned-exception-object -Werror=return-type
> >>> > > >> >>> -Werror=dangling-else -Werror=return-stack-address
> -D_THREAD_SAFE
> >>> > > >> >>> -pthread -std=gnu++14 -MD -MT
> >>> > > >> >>> src/CMakeFiles/Audacity.dir/import/Import.cpp.o -MF
> >>> > > >> >>> src/CMakeFiles/Audacity.dir/import/Import.cpp.o.d -o
> >>> > > >> >>> src/CMakeFiles/Audacity.dir/import/Import.cpp.o -c
> >>> > > >> >>>
> /backup/obj/usr/ports/audio/audacity3/work/audacity-minsrc-3.0.0/
> >>> > > >> >>> src/import/Import.cpp
> >>> > > >> >>> FAILED: src/CMakeFiles/Audacity.dir/import/Import.cpp.o
> >>> > > >> >>> /usr/bin/c++ -DAudacity_EXPORTS -DBUILDING_AUDACITY -DCMAKE
> >>> > > >> >>> -DHAVE_LRINT -DHAVE_LRINTF -DHAVE_MLOCK -
> >>> > > DWXINTL_NO_GETTEXT_MACRO
> >>> > > >> >>> -DWXUSINGDLL -D_FILE_OFFSET_BITS=64 -D_THREAD_SAFE -
> >>> > > D__WXGTK__
> >>> > > >> >>> -Isrc/private
> >>> > > >> >>>
> -I/backup/obj/usr/ports/audio/audacity3/work/audacity-minsrc-3.0.
> >>> > > >> >>> 0/include
> >>> > > >> >>>
> -I/backup/obj/usr/ports/audio/audacity3/work/audacity-minsrc-3.0.
> >>> > > >> >>> 0/src
> >>> > > >> >>> -I/usr/local/lib/wx/include/gtk3-unicode-3.1
> >>> > > >> >>> -I/usr/local/include/wx-3.1
> >>> > > >> >>>
> -I/backup/obj/usr/ports/audio/audacity3/work/audacity-minsrc-3.0.
> >>> > > >> >>> 0/lib-src/lame
> >>> > > >> >>>
> -I/backup/obj/usr/ports/audio/audacity3/work/audacity-minsrc-3.0.
> >>> > > >> >>> 0/lib-src/portsmf/include
> >>> > > >> >>>
> -I/backup/obj/usr/ports/audio/audacity3/work/audacity-minsrc-3.0.
> >>> > > >> >>> 0/lib-src/libnyquist
> >>> > > >> >>>
> -I/backup/obj/usr/ports/audio/audacity3/work/audacity-minsrc-3.0.
> >>> > > >> >>> 0/lib-src/portmixer/include
> >>> > > >> >>>
> -I/backup/obj/usr/ports/audio/audacity3/work/audacity-minsrc-3.0.
> >>> > > >> >>> 0/lib-src/libsbsms/include -isystem /usr/local/include
> -isystem
> >>> > > >> >>> /usr/local/include/opus -isystem
> /usr/local/include/soundtouch
> >>> > > >> >>> -isystem /usr/local/include/glib-2.0 -isystem
> >>> > > >> >>> /usr/local/lib/glib-2.0/include -isystem
> >>> > > >> >>> /usr/local/include/gtk-3.0 -isystem
> /usr/local/include/pango-1.0
> >>> > > >> >>> -isystem /usr/local/include/fribidi -isystem
> >>> > > >> >>> /usr/local/include/cairo -isystem
> /usr/local/include/pixman-1
> >>> > > >> >>> -isystem
> >>> > > >> >>> /usr/local/include/freetype2 -isystem
> /usr/local/include/libdrm
> >>> > > >> >>> -isystem /usr/local/include/libpng16 -isystem
> >>> > > >> >>> /usr/local/include/harfbuzz -isystem
> >>> > > >> >>> /usr/local/include/gdk-pixbuf-2.0 -isystem
> >>> > > >> >>> /usr/local/include/gio-unix-2.0 -isystem
> >>> > > >> >>> /usr/local/include/libepoll-shim -isystem
> >>> > > >> >>> /usr/local/include/atk-1.0 -isystem
> >>> > > >> >>> /usr/local/include/at-spi2-atk/2.0 -isystem
> >>> > > >> >>> /usr/local/include/dbus-1.0 -isystem
> >>> > > >> >>> /usr/local/lib/dbus-1.0/include -isystem
> >>> > > >> >>> /usr/local/include/at-spi-2.0 -O2 -pipe -march=westmere
> >>> > > >> >>> -fstack-protector-strong -fno-strict-aliasing -O2 -pipe
> >>> > > >> >>> -march=westmere -fstack-protector-strong
> -fno-strict-aliasing
> >>> > > >> >>> -Wno-underaligned-exception-object -Werror=return-type
> >>> > > >> >>> -Werror=dangling-else -Werror=return-stack-address
> -D_THREAD_SAFE
> >>> > > >> >>> -pthread -std=gnu++14 -MD -MT
> >>> > > >> >>> src/CMakeFiles/Audacity.dir/import/Import.cpp.o -MF
> >>> > > >> >>> src/CMakeFiles/Audacity.dir/import/Import.cpp.o.d -o
> >>> > > >> >>> src/CMakeFiles/Audacity.dir/import/Import.cpp.o -c
> >>> > > >> >>>
> /backup/obj/usr/ports/audio/audacity3/work/audacity-minsrc-3.0.0/
> >>> > > >> >>> src/import/Import.cpp
> >>> > > >> >>> /backup/obj/usr/ports/audio/audacity3/work/audacity-minsrc-
> >>> > > 3.0.0/src/import/Import.cpp:806:20:
> >>> > > >> >>> error: use of undeclared identifier 'FFmpegLibsInst'
> >>> > > >> >>>                   !FFmpegLibsInst()
> >>> > > >> >>>                    ^
> >>> > > >> >>> 1 error generated.
> >>> > > >> >>> ninja: build stopped: subcommand failed.
> >>> > > >> >>> *** Error code 1
> >>> > > >> >>>
> >>> > > >> >>> Stop.
> >>> > > >> >>>
> >>> > > >> >>>
> >>> > > >> >>> _______________________________________________
> >>> > > >> >>> audacity-devel mailing list
> >>> > > >> >>> [email protected]
> >>> > > >> >>> https://lists.sourceforge.net/lists/listinfo/audacity-devel
> >>> > > >> >
> >>> > > >> > _______________________________________________
> >>> > > >> > audacity-devel mailing list
> >>> > > >> > [email protected]
> >>> > > >> > https://lists.sourceforge.net/lists/listinfo/audacity-devel
> >>> > > >>
> >>> > > >>
> >>> > > >> _______________________________________________
> >>> > > >> audacity-devel mailing list
> >>> > > >> [email protected]
> >>> > > >> https://lists.sourceforge.net/lists/listinfo/audacity-devel
> >>> > > >
> >>> > > > _______________________________________________
> >>> > > > audacity-devel mailing list
> >>> > > > [email protected]
> >>> > > > https://lists.sourceforge.net/lists/listinfo/audacity-devel
> >>> > >
> >>> > >
> >>> > > _______________________________________________
> >>> > > audacity-devel mailing list
> >>> > > [email protected]
> >>> > > https://lists.sourceforge.net/lists/listinfo/audacity-devel
> >>> >
> >>> >
> >>> >
> >>> > _______________________________________________
> >>> > audacity-devel mailing list
> >>> > [email protected]
> >>> > https://lists.sourceforge.net/lists/listinfo/audacity-devel
> >>>
> >>>
> >>> _______________________________________________
> >>> audacity-devel mailing list
> >>> [email protected]
> >>> https://lists.sourceforge.net/lists/listinfo/audacity-devel
> >>
> >> _______________________________________________
> >> audacity-devel mailing list
> >> [email protected]
> >> https://lists.sourceforge.net/lists/listinfo/audacity-devel
> >
> > _______________________________________________
> > audacity-devel mailing list
> > [email protected]
> > https://lists.sourceforge.net/lists/listinfo/audacity-devel
>
>
> _______________________________________________
> audacity-devel mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/audacity-devel
>

_______________________________________________
audacity-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/audacity-devel