Two GitHub PRs
Ian McInerney <[email protected]> Thu, 22 Apr 2021 18:03:51 +0100
| Newsgroups | gmane.comp.audio.audacity.devel |
|---|---|
| Message-ID | <CACp=Vfb8=+ZME5_G1kanStfnb3RhHWpMSiFMjYT0RUhxAczYwg@mail.gmail.com> |
I have recently made two GitHub PRs ( https://github.com/audacity/audacity/pull/816 and https://github.com/audacity/audacity/pull/818) that I would like for someone to review + hopefully merge. The first (#816) cleans up two different warning types that are enabled by the default build flags in Fedora. The Wreorder warnings are simply just about initializer lists with an order different from the class layout - so it is easily fixed by reordering the initializer list. The second is about calls to std::move that penalize the compiler from doing NRVA, and these are fixed by removing those calls and letting the compiler optimize away the move/copy and construct the value in-place. The second PR (#818) fixes a type difference between the declaration and definition for a function in mod-script-pipe module - the second argument was either an int or size_t (which aren't always the same). This PR makes the second argument a size_t everywhere. Thanks, -Ian _______________________________________________ audacity-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/audacity-devel