Strange commented code in Echo canceller: a bug ?

Frédérik Rouleau <[email protected]> Fri, 17 Feb 2012 15:36:39 +0100
Newsgroups gmane.comp.audio.compression.speex.devel
Message-ID <CALrvw6EJVfCZ894x=0epUvr6FCUJNmBE3-2rtNO8GWmaB0jNCQ@mail.gmail.com>
Hello,

I was reading the git code of the AEC part when I was disapointed by the
code line 1189 in file libspeex/mdf.c:

      /* If filter isn't adapted yet, all we can do is take the far end
signal directly */
      /* moved earlier: for (i=0;i<N;i++)
      st->last_y[i] = st->x[i];*/

This code from function speex_echo_cancellation() is supposed to have been
moved earlier but I cannot find where. All the search I have done conclude
that when AEC is not adapted the last_y[] vector is not updated.

Am I missing something or is it a bug ?


Regards,

_______________________________________________
Speex-dev mailing list
[email protected]
http://lists.xiph.org/mailman/listinfo/speex-dev