Re: [PATCH] arm: Remove a superfluous 's' suffix from the cmp instruction

On Fri, Feb 7, 2014 at 12:42 PM, Martin Storsjo <[email protected]> wrote:
> The 's' suffix on the cmp instruction is deprecated and
> superfluous since the cmp instruction always sets conditional
> flags.
>
> This fixes building for iOS with inline assembly enabled.
> ---
>  libspeex/filters_arm4.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/libspeex/filters_arm4.h b/libspeex/filters_arm4.h
> index 7a74042..2c64625 100644
> --- a/libspeex/filters_arm4.h
> +++ b/libspeex/filters_arm4.h
> @@ -46,9 +46,9 @@ int normalize16(const spx_sig_t *x, spx_word16_t *y, spx_sig_t max_scale, int le
>           ".normalize16loop1%=: \n"
>
>           "\tldr %4, [%0], #4 \n"
> -         "\tcmps %4, %1 \n"
> +         "\tcmp %4, %1 \n"
>           "\tmovgt %1, %4 \n"
> -         "\tcmps %4, %3 \n"
> +         "\tcmp %4, %3 \n"
>           "\tmovlt %3, %4 \n"
>
>           "\tsubs %2, %2, #1 \n"
> --
> 1.8.3.4 (Apple Git-47)

Merged, thanks.