Re: Sendig patches to speex

--001a113b9e06ad359f053d14f519
Content-Type: multipart/alternative; boundary=001a113b9e06ad3598053d14f517

--001a113b9e06ad3598053d14f517
Content-Type: text/plain; charset=UTF-8

Thanks Tristan
The patch is attached and applies to speexdsp's master.
The warnings came from Wireshark's coverity scans.
Dario.

On Tue, Sep 20, 2016 at 10:56 PM, Tristan Matthews <[email protected]>
wrote:

> Hi Dario,
>
> On Wed, Aug 10, 2016 at 6:07 AM, Dario Lombardo <[email protected]> wrote:
> > Hello devels
> > I'm a core developer of the wireshark project. In our audit process, a
> piece
> > of code of speex (the copy we maintain inside wireshark) showed a flaw. I
> > have a couple of patches I'd like to send you but I can't find details
> about
> > the submission process. Can you help me?
>
> You can send your patches to this mailing list for review. Ideally
> they would apply cleanly to the master branch of speex hosted here:
> https://git.xiph.org/?p=speex.git;a=summary
>
> Best,
> Tristan
>
> >
> > --
> >
> > Naima is online.
> >
> >
> > _______________________________________________
> > Speex-dev mailing list
> > [email protected]
> > http://lists.xiph.org/mailman/listinfo/speex-dev
> >
>



-- 

Naima is online.

--001a113b9e06ad3598053d14f517
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Thanks Tristan<div>The patch is attached and applies to sp=
eexdsp&#39;s master.</div><div>The warnings came from Wireshark&#39;s cover=
ity scans.</div><div>Dario.</div></div><div class=3D"gmail_extra"><br><div =
class=3D"gmail_quote">On Tue, Sep 20, 2016 at 10:56 PM, Tristan Matthews <s=
pan dir=3D"ltr">&lt;<a href=3D"mailto:[email protected]" target=3D"_blank=
">[email protected]</a>&gt;</span> wrote:<br><blockquote class=3D"gmail_q=
uote" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1e=
x">Hi Dario,<br>
<br>
On Wed, Aug 10, 2016 at 6:07 AM, Dario Lombardo &lt;<a href=3D"mailto:lomat=
[email protected]">[email protected]</a>&gt; wrote:<br>
&gt; Hello devels<br>
&gt; I&#39;m a core developer of the wireshark project. In our audit proces=
s, a piece<br>
&gt; of code of speex (the copy we maintain inside wireshark) showed a flaw=
. I<br>
&gt; have a couple of patches I&#39;d like to send you but I can&#39;t find=
 details about<br>
&gt; the submission process. Can you help me?<br>
<br>
You can send your patches to this mailing list for review. Ideally<br>
they would apply cleanly to the master branch of speex hosted here:<br>
<a href=3D"https://git.xiph.org/?p=3Dspeex.git;a=3Dsummary" rel=3D"noreferr=
er" target=3D"_blank">https://git.xiph.org/?p=3Dspeex.<wbr>git;a=3Dsummary<=
/a><br>
<br>
Best,<br>
Tristan<br>
<span class=3D"HOEnZb"><font color=3D"#888888"><br>
&gt;<br>
&gt; --<br>
&gt;<br>
&gt; Naima is online.<br>
&gt;<br>
&gt;<br>
&gt; ______________________________<wbr>_________________<br>
&gt; Speex-dev mailing list<br>
&gt; <a href=3D"mailto:[email protected]">[email protected]</a><br>
&gt; <a href=3D"http://lists.xiph.org/mailman/listinfo/speex-dev" rel=3D"no=
referrer" target=3D"_blank">http://lists.xiph.org/mailman/<wbr>listinfo/spe=
ex-dev</a><br>
&gt;<br>
</font></span></blockquote></div><br><br clear=3D"all"><div><br></div>-- <b=
r><div class=3D"gmail_signature" data-smartmail=3D"gmail_signature"><div di=
r=3D"ltr"><div><pre cols=3D"72">Naima is online.</pre></div></div></div>
</div>

--001a113b9e06ad3598053d14f517--

--001a113b9e06ad359f053d14f519
Content-Type: text/x-patch; charset=US-ASCII; 
	name="0001-codecs-speex-add-checks-in-speex_resampler_init_frac.patch"
Content-Disposition: attachment; 
	filename="0001-codecs-speex-add-checks-in-speex_resampler_init_frac.patch"
Content-Transfer-Encoding: base64
X-Attachment-Id: f_ite447ec0

RnJvbSA5OWJlOGFkYjIzOWM4MTU4ZTYxYTQ4MjdlYjM4ZmZlM2NiYTUzMTdiIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBEYXJpbyBMb21iYXJkbyA8bG9tYXRvQGdtYWlsLmNvbT4KRGF0
ZTogVGh1LCAyMiBTZXAgMjAxNiAxMTowMzowNyArMDIwMApTdWJqZWN0OiBbUEFUQ0hdIGNvZGVj
cy9zcGVleDogYWRkIGNoZWNrcyBpbgogc3BlZXhfcmVzYW1wbGVyX2luaXRfZnJhYy9zZXRfcmF0
ZV9mcmFjLgoKQWRkIGNoZWNrcyB0byBhdm9pZCBkZW5fcmF0ZSBhbmQgbnVtX3JhdGUgdG8gYmUg
c2V0IHRvIDAuCgpDaGFuZ2UtSWQ6IElhNDg4MDUyMWU3YWI3M2QwZmRjNDQzNzdmNGJhZGFkYjA5
MzY1NDcxClJldmlld2VkLWJ5OiBQZXRlciBXdSA8cGV0ZXJAbGVrZW5zdGV5bi5ubD4KUmV2aWV3
ZWQtYnk6IEFuZGVycyBCcm9tYW4gPGEuYnJvbWFuNThAZ21haWwuY29tPgpTaWduZWQtb2ZmLWJ5
OiBEYXJpbyBMb21iYXJkbyA8bG9tYXRvQGdtYWlsLmNvbT4KLS0tCiBsaWJzcGVleGRzcC9yZXNh
bXBsZS5jIHwgNiArKysrKy0KIDEgZmlsZSBjaGFuZ2VkLCA1IGluc2VydGlvbnMoKyksIDEgZGVs
ZXRpb24oLSkKCmRpZmYgLS1naXQgYS9saWJzcGVleGRzcC9yZXNhbXBsZS5jIGIvbGlic3BlZXhk
c3AvcmVzYW1wbGUuYwppbmRleCBhYWRmNjg1Li45ZmJiNWRkIDEwMDY0NAotLS0gYS9saWJzcGVl
eGRzcC9yZXNhbXBsZS5jCisrKyBiL2xpYnNwZWV4ZHNwL3Jlc2FtcGxlLmMKQEAgLTgwMiw3ICs4
MDIsNyBAQCBFWFBPUlQgU3BlZXhSZXNhbXBsZXJTdGF0ZSAqc3BlZXhfcmVzYW1wbGVyX2luaXRf
ZnJhYyhzcHhfdWludDMyX3QgbmJfY2hhbm5lbHMsCiAgICBTcGVleFJlc2FtcGxlclN0YXRlICpz
dDsKICAgIGludCBmaWx0ZXJfZXJyOwogCi0gICBpZiAocXVhbGl0eSA+IDEwIHx8IHF1YWxpdHkg
PCAwKQorICAgaWYgKG5iX2NoYW5uZWxzID09IDAgfHwgcmF0aW9fbnVtID09IDAgfHwgcmF0aW9f
ZGVuID09IDAgfHwgcXVhbGl0eSA+IDEwIHx8IHF1YWxpdHkgPCAwKQogICAgewogICAgICAgaWYg
KGVycikKICAgICAgICAgICplcnIgPSBSRVNBTVBMRVJfRVJSX0lOVkFMSURfQVJHOwpAQCAtMTEx
MSw2ICsxMTExLDEwIEBAIEVYUE9SVCBpbnQgc3BlZXhfcmVzYW1wbGVyX3NldF9yYXRlX2ZyYWMo
U3BlZXhSZXNhbXBsZXJTdGF0ZSAqc3QsIHNweF91aW50MzJfdCByCiAgICBzcHhfdWludDMyX3Qg
ZmFjdDsKICAgIHNweF91aW50MzJfdCBvbGRfZGVuOwogICAgc3B4X3VpbnQzMl90IGk7CisKKyAg
IGlmIChyYXRpb19udW0gPT0gMCB8fCByYXRpb19kZW4gPT0gMCkKKyAgICAgIHJldHVybiBSRVNB
TVBMRVJfRVJSX0lOVkFMSURfQVJHOworCiAgICBpZiAoc3QtPmluX3JhdGUgPT0gaW5fcmF0ZSAm
JiBzdC0+b3V0X3JhdGUgPT0gb3V0X3JhdGUgJiYgc3QtPm51bV9yYXRlID09IHJhdGlvX251bSAm
JiBzdC0+ZGVuX3JhdGUgPT0gcmF0aW9fZGVuKQogICAgICAgcmV0dXJuIFJFU0FNUExFUl9FUlJf
U1VDQ0VTUzsKIAotLSAKMi43LjQKCg==
--001a113b9e06ad359f053d14f519
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: base64
Content-Disposition: inline

X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KU3BlZXgtZGV2
IG1haWxpbmcgbGlzdApTcGVleC1kZXZAeGlwaC5vcmcKaHR0cDovL2xpc3RzLnhpcGgub3JnL21h
aWxtYW4vbGlzdGluZm8vc3BlZXgtZGV2Cg==

--001a113b9e06ad359f053d14f519--